From mboxrd@z Thu Jan  1 00:00:00 1970
From: Pete Zaitcev <zaitcev@redhat.com>
Subject: Re: [Patch] libcldc,cldcli: Use humanized error messages
Date: Wed, 26 Aug 2009 20:50:03 -0600
Message-ID: <20090826205003.79e4b2af@redhat.com>
References: <20090826200625.4434935f@redhat.com>
	<4A95EEEA.9000301@garzik.org>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Return-path: <hail-devel-owner@vger.kernel.org>
In-Reply-To: <4A95EEEA.9000301@garzik.org>
Sender: hail-devel-owner@vger.kernel.org
List-ID: <hail-devel.vger.kernel.org>
Content-Type: text/plain; charset="us-ascii"
To: Jeff Garzik <jeff@garzik.org>
Cc: Project Hail List <hail-devel@vger.kernel.org>

On Wed, 26 Aug 2009 22:26:50 -0400, Jeff Garzik <jeff@garzik.org> wrote:
> On 08/26/2009 10:06 PM, Pete Zaitcev wrote:

> > Signed-off-by: Pete Zaitcev<zaitcev@redhat.com>
> 
> applied a modified version, see attached...  after that short IRC 
> discussion, I think an array with a range check would be nicer than 
> coding it (though the C compiler should make a nice, efficient table 
> from 'switch' statement for us...)

I don't think it's enough. Look:

+static const char *cld_errlist[] =
+{
+	[CLE_OK]		= "Success",
+	[CLE_SESS_EXISTS]	= "Session exists",

When you do indexed initializations, it's possible to create
empty array elements (currently there are none because indexes
are contiguous). So, the following needs a NULL check:

+	return cld_errlist[ecode];
+}

-- Pete