From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MgSL6-0007ih-H1 for mharc-grub-devel@gnu.org; Wed, 26 Aug 2009 19:55:40 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MgSL5-0007i5-MP for grub-devel@gnu.org; Wed, 26 Aug 2009 19:55:39 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MgSL0-0007cu-7T for grub-devel@gnu.org; Wed, 26 Aug 2009 19:55:39 -0400 Received: from [199.232.76.173] (port=59733 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MgSKz-0007cQ-Q0 for grub-devel@gnu.org; Wed, 26 Aug 2009 19:55:33 -0400 Received: from smarthost03.mail.zen.net.uk ([212.23.3.142]:48371) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MgSKy-0004UX-V0 for grub-devel@gnu.org; Wed, 26 Aug 2009 19:55:33 -0400 Received: from [82.69.40.219] (helo=riva.pelham.vpn.ucam.org) by smarthost03.mail.zen.net.uk with esmtp (Exim 4.63) (envelope-from ) id 1MgSKv-0002nR-KX for grub-devel@gnu.org; Wed, 26 Aug 2009 23:55:31 +0000 Received: from cjwatson by riva.pelham.vpn.ucam.org with local (Exim 3.36 #1 (Debian)) for grub-devel@gnu.org id 1MgSKl-0006mN-00; Thu, 27 Aug 2009 00:55:19 +0100 Date: Thu, 27 Aug 2009 00:55:18 +0100 From: Colin Watson To: grub-devel@gnu.org Message-ID: <20090826235518.GV11691@riva.ucam.org> Mail-Followup-To: grub-devel@gnu.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit User-Agent: Mutt/1.5.18 (2008-05-17) X-Originating-Smarthost03-IP: [82.69.40.219] X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: [PATCH] Compiler warning in grub_cmdline_get X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Aug 2009 23:55:40 -0000 I don't think this can actually cause a real problem, but it's a compiler warning since it might (e.g. if prompt ever contained "%"). /home/cjwatson/src/ubuntu/grub2/tmp/grub2-1.96+20090826/normal/cmdline.c: In function ‘grub_cmdline_get’: /home/cjwatson/src/ubuntu/grub2/tmp/grub2-1.96+20090826/normal/cmdline.c:276: warning: format not a string literal and no format arguments 2009-08-27 Colin Watson * normal/cmdline.c (grub_cmdline_get): Supply a format string as the first argument to grub_printf. Index: normal/cmdline.c =================================================================== --- normal/cmdline.c (revision 2535) +++ normal/cmdline.c (working copy) @@ -273,7 +273,7 @@ if ((grub_getxy () >> 8) != 0) grub_putchar ('\n'); - grub_printf (prompt); + grub_printf ("%s", prompt); xpos = plen; ystart = ypos = (grub_getxy () & 0xFF); -- Colin Watson [cjwatson@ubuntu.com]