All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcelo Tosatti <mtosatti@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: kvm@vger.kernel.org
Subject: Re: [patch 2/5] KVM: reintroduce guest mode bit and unify remote request code
Date: Thu, 27 Aug 2009 09:45:26 -0300	[thread overview]
Message-ID: <20090827124526.GA3476@amt.cnet> (raw)
In-Reply-To: <4A96409B.3020001@redhat.com>

On Thu, Aug 27, 2009 at 11:15:23AM +0300, Avi Kivity wrote:
> On 08/27/2009 04:20 AM, Marcelo Tosatti wrote:
>> Split KVM_REQ_KICKED in two bits: KVM_VCPU_KICKED, to indicate
>> whether a vcpu has been IPI'ed, and KVM_VCPU_GUEST_MODE, in a separate
>> vcpu_state variable.
>>
>> Unify remote requests with kvm_vcpu_kick.
>>
>> Synchronous requests wait on KVM_VCPU_GUEST_MODE, via wait_on_bit/wake_up_bit.
>>
>>    
>
> I did miss guest_mode.
>
>> +	unsigned long vcpu_state;
>>    
>
> Why not bool guest_mode?  Saves two atomics per exit.

It must be atomic since GUEST_MODE / VCPU_KICKED bits are manipulated by
multiple CPU's.


  reply	other threads:[~2009-08-27 12:58 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-27  1:20 [patch 0/5] unify remote request and kvm_vcpu_kick IPI mechanism Marcelo Tosatti
2009-08-27  1:20 ` [patch 1/5] KVM: move kvm_vcpu_kick to virt/kvm/kvm_main.c Marcelo Tosatti
2009-08-27  1:20 ` [patch 2/5] KVM: reintroduce guest mode bit and unify remote request code Marcelo Tosatti
2009-08-27  8:15   ` Avi Kivity
2009-08-27 12:45     ` Marcelo Tosatti [this message]
2009-08-27 13:24       ` Avi Kivity
2009-08-27 14:07         ` Marcelo Tosatti
2009-08-28  7:06           ` Avi Kivity
2009-08-28  7:22             ` Avi Kivity
2009-08-27  8:25   ` Avi Kivity
2009-08-27 12:58     ` Marcelo Tosatti
2009-08-27  1:20 ` [patch 3/5] KVM: switch REQ_TLB_FLUSH/REQ_MMU_RELOAD to kvm_vcpus_request Marcelo Tosatti
2009-08-27  1:20 ` [patch 4/5] KVM: remove make_all_cpus_request Marcelo Tosatti
2009-08-27  1:20 ` [patch 5/5] KVM: x86: drop duplicat kvm_flush_remote_tlbs Marcelo Tosatti
2009-08-27 15:54 ` [RFC] KVM: x86: conditionally acquire/release slots_lock on entry/exit Marcelo Tosatti
2009-08-27 16:27   ` Avi Kivity
2009-08-27 22:59     ` Marcelo Tosatti
2009-08-28  6:50       ` Avi Kivity
2009-09-10 22:30         ` Marcelo Tosatti
2009-09-13 15:42           ` Avi Kivity
2009-09-13 16:26             ` Paul E. McKenney
2009-09-13 22:49               ` Marcelo Tosatti
2009-09-14  5:03                 ` Avi Kivity
2009-09-14  7:17                   ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090827124526.GA3476@amt.cnet \
    --to=mtosatti@redhat.com \
    --cc=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.