From: Frederic Weisbecker <fweisbec@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Peter Zijlstra <peterz@infradead.org>,
Steven Rostedt <rostedt@goodmis.org>,
Arjan van de Ven <arjan@infradead.org>,
Paul Mackerras <paulus@samba.org>,
Thomas Gleixner <tglx@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Christoph Hellwig <hch@infradead.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] perf: remove PERF_SAMPLE_RAW
Date: Thu, 27 Aug 2009 15:35:02 +0200 [thread overview]
Message-ID: <20090827133455.GB6058@nowhere> (raw)
In-Reply-To: <20090827084321.GD2131@elte.hu>
On Thu, Aug 27, 2009 at 10:43:21AM +0200, Ingo Molnar wrote:
> * Peter Zijlstra <peterz@infradead.org> wrote:
>
> > Apparently people think trace-events became an ABI the moment perf
> > exported them, regardless what the text surrounding
> > PERF_SAMPLE_RAW said about the opaqueness of the data provided.
>
> Well it's still opaque and the descriptor of what it means is in
> debugfs so it's not an ABI as the comment says.
>
> > I'm not willing to make anything trace related into an ABI, hence
> > remove this.
>
> This removes quite a bit of nice functionality we already have, so i
> think it's (way) too heavy handed.
>
> I think what we want is the golden middle: a per tracepoint
> property. I.e. we would provide:
>
> TRACE_EVENT_STABLE()
>
> or TRACE_EVENT_CORE() or TRACE_EVENT_ABI() - which carries a 'will
> maintain this as an ABI' promise from the maintainer who adds it.
Why? The format files stand to avoid that.
I don't understand this debate.
> Also, tracepoints are a unidirectional channel of information - in
> practice those are way easier to handle as an ABI than other ABIs
> such as behavior, semantics, etc. So i'd expect there to be a
> healthy set of 'stable' tracepoints.
>
> Ingo
next prev parent reply other threads:[~2009-08-27 13:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-27 8:17 [PATCH] perf: remove PERF_SAMPLE_RAW Peter Zijlstra
2009-08-27 8:43 ` Ingo Molnar
2009-08-27 9:04 ` Peter Zijlstra
2009-08-27 13:35 ` Frederic Weisbecker [this message]
2009-08-27 13:26 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090827133455.GB6058@nowhere \
--to=fweisbec@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=arjan@infradead.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.