All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pascal Bouchareine <pascal@gandi.net>
To: xen-devel@lists.xensource.com
Subject: cannot access memory beyond end of bootstrap direct-map area
Date: Thu, 27 Aug 2009 19:28:17 +0200	[thread overview]
Message-ID: <20090827172817.GA25165@bar> (raw)

[-- Attachment #1: Type: text/plain, Size: 566 bytes --]

Hi,

Investigating the above message during xen 3.3 boot, found we left
a wrong assumption [modules_length == (mod[n].end - mod[0].start)]
in move_memory call, leading to an access above BOOTSTRAP_DIRECTMAP_END
and this panic on x86_32.

In my understanding Keir's patch 18630 was fixing this kind of problem
and I'm wondering why this move_memory call didn't go away with it ?

If this were ok, attached patch fixes the panic on my system.

Cheers,
Pascal

-- 
\o/   Pascal Bouchareine - Gandi 
 g    0170393757           15, place de la Nation - 75011 Paris      

[-- Attachment #2: xen-setup-remap-modules.patch --]
[-- Type: text/x-diff, Size: 1045 bytes --]

Signed-off-by: Pascal Bouchareine <pascal@gandi.net>

diff -r d9289e28e5e7 xen/arch/x86/setup.c
--- a/xen/arch/x86/setup.c	Thu Aug 06 13:29:39 2009 +0100
+++ b/xen/arch/x86/setup.c	Thu Aug 27 18:53:08 2009 +0200
@@ -737,11 +737,6 @@ void __init __start_xen(unsigned long mb
         if ( !initial_images_start && (s < e) && ((e-s) >= modules_length) )
         {
             initial_images_end = e;
-            e = (e - modules_length) & PAGE_MASK;
-            initial_images_start = e;
-            move_memory(initial_images_start, 
-                        mod[0].mod_start, mod[mbi->mods_count-1].mod_end);
-            e += modules_length;
             for ( j = mbi->mods_count-1; j >= 0; j-- )
             {
                 e -= mod[j].mod_end - mod[j].mod_start;
@@ -749,6 +744,7 @@ void __init __start_xen(unsigned long mb
                 mod[j].mod_end += e - mod[j].mod_start;
                 mod[j].mod_start = e;
             }
+	    initial_images_start = e;
         }
 
         if ( !kexec_crash_area.start && (s < e) &&

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

             reply	other threads:[~2009-08-27 17:28 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-27 17:28 Pascal Bouchareine [this message]
2009-08-27 18:55 ` cannot access memory beyond end of bootstrap direct-map area Keir Fraser
2009-08-27 21:41   ` Pascal Bouchareine
2009-08-28  6:38     ` Keir Fraser
2009-08-28  7:44       ` Pascal Bouchareine
  -- strict thread matches above, loose matches on Subject: below --
2010-03-18  9:18 Cannot " Florian Wagner
2010-03-18  9:22 ` Keir Fraser
2010-03-18 22:03 ` Keir Fraser
2010-03-24  7:16   ` Florian Wagner
2010-03-24  8:35     ` Keir Fraser
2010-03-24  9:32       ` Florian Wagner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090827172817.GA25165@bar \
    --to=pascal@gandi.net \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.