From: Gleb Natapov <gleb@redhat.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
Glauber Costa <glommer@redhat.com>,
qemu-devel@nongnu.org, avi@redhat.com
Subject: Re: [Qemu-devel] Re: [PATCH v3] introduce on_vcpu
Date: Fri, 28 Aug 2009 09:18:47 +0300 [thread overview]
Message-ID: <20090828061846.GA22585@redhat.com> (raw)
In-Reply-To: <4A973530.4040002@us.ibm.com>
On Thu, Aug 27, 2009 at 08:38:56PM -0500, Anthony Liguori wrote:
> Glauber Costa wrote:
> >qemu-kvm uses a TLS variable for that, to guarantee that we're in the same thread
> >as our calling context. I like this idea. if we have io-thread disabled, we're always
> >in the same thread, and will always execute the function directly as we used to do
> >before on_vcpu().
> >
> >I do however remember anthony bending towards issuing a gettid() instead of using
> >a TLS var. I'm fine with both. Anthony, avi, you guys have a word here?
>
> Since we already keep the tid in the vcpu structure, it seems to
> make more sense to ask "am I this vcpu thread" by doing gettid() ==
> env->tid than by maintaining a new global tls variable.
>
What is the problem with tls variables? Why do unneeded system call?
--
Gleb.
next prev parent reply other threads:[~2009-08-28 6:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-16 21:55 [Qemu-devel] [PATCH v3] introduce on_vcpu Glauber Costa
2009-08-27 17:15 ` [Qemu-devel] " Jan Kiszka
2009-08-27 17:40 ` Glauber Costa
2009-08-27 17:45 ` Jan Kiszka
2009-08-28 1:18 ` Glauber Costa
2009-08-28 1:38 ` Anthony Liguori
2009-08-28 1:58 ` Glauber Costa
2009-08-28 6:18 ` Gleb Natapov [this message]
2009-08-29 1:22 ` Jamie Lokier
2009-08-31 11:35 ` Glauber Costa
2009-08-31 12:04 ` Jamie Lokier
2009-08-31 12:14 ` Glauber Costa
2009-08-31 12:21 ` Jan Kiszka
2009-08-31 22:25 ` Jamie Lokier
2009-08-31 12:57 ` Glauber Costa
2009-09-01 0:55 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090828061846.GA22585@redhat.com \
--to=gleb@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=glommer@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.