From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Mh0sL-0001zQ-Oq for mharc-grub-devel@gnu.org; Fri, 28 Aug 2009 08:48:18 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mh0sG-0001xd-PQ for grub-devel@gnu.org; Fri, 28 Aug 2009 08:48:13 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mh0sB-0001w3-Ml for grub-devel@gnu.org; Fri, 28 Aug 2009 08:48:11 -0400 Received: from [199.232.76.173] (port=54583 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mh0sA-0001vf-0Q for grub-devel@gnu.org; Fri, 28 Aug 2009 08:48:06 -0400 Received: from xvm-190-8.ghst.net ([217.70.190.8]:59915 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Mh0s9-0007Ku-E3 for grub-devel@gnu.org; Fri, 28 Aug 2009 08:48:05 -0400 Received: from [192.168.10.10] (helo=localhost) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1Mh0s7-0002Ul-NM for grub-devel@gnu.org; Fri, 28 Aug 2009 14:48:03 +0200 Received: from rmh by localhost with local (Exim 4.69) (envelope-from ) id 1Mh0s7-0003wA-6u for grub-devel@gnu.org; Fri, 28 Aug 2009 14:48:03 +0200 Date: Fri, 28 Aug 2009 14:48:03 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090828124803.GC15030@thorin> References: <20090825211317.GA23440@thorin> <793523500908262120t65a88100y25f6c5e75a4979e0@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <793523500908262120t65a88100y25f6c5e75a4979e0@mail.gmail.com> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: [PATCH] Remove framework for external modules X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Aug 2009 12:48:13 -0000 On Wed, Aug 26, 2009 at 09:20:58PM -0700, Joe Auricchio wrote: > On Tue, Aug 25, 2009 at 14:13, Robert Millan wrote: > > > > My bad... > > > > When I proposed adding a framework for building GRUB modules externally, I > > was expecting it would end up being used.  I had grub-extras in mind. > > > > But it became much simpler and straightforwarded to build grub-extras by > > overlaiing it into GRUB tree and doing a one-line change in GRUB Makefile.in. > > > > So I wonder if there's anyone reliing on this.  I believe there isn't, and I > > I'm using it. > > I am (my employer is) writing a set of modules to make grub do > something it doesn't do yet. My employer prefers that I not discuss > details at this time. > > I really like keeping the module code completely separate from the > common grub code. If the external build stuff goes away, I can work > around it, but it's not preferred. > > > > noticed that it's a nuissance because it installs headers in /usr/include which > > may later be dragged in to a newer version of GRUB, causing breakage. > > I don't need headers in /usr/include. In fact I am happy with an -I > flag pointing to the grub source dir. I vote we stop installing the > headers. > > > So I admit having a bad idea and propose to undo it.  Maintaining features is > > costly, we should only maintain features that are useful. > > I understand this and I agree completely. But it doesn't seem to cost > us anything *right now* to keep build_env.mk and the 'idea' of > external modules. Can we leave this code alone until a real problem > appears? I don't think it's hurting anyone right now? Only the headers are problematic. As for the rest, I suggest you look at how grub-extras does this now, but if you still need this I don't mind keeping it around. Do you mind if we stop installing headers then? > (footnote) We are applying GPL license to these modules, but they'll > never end up in the grub tree. Our requirements are too weird. You > won't want to merge this code, believe me. I understand. Good luck with it! -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."