From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Mh0t0-0002Ba-UC for mharc-grub-devel@gnu.org; Fri, 28 Aug 2009 08:48:59 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mh0sx-0002AG-LU for grub-devel@gnu.org; Fri, 28 Aug 2009 08:48:56 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mh0sr-00028o-87 for grub-devel@gnu.org; Fri, 28 Aug 2009 08:48:55 -0400 Received: from [199.232.76.173] (port=54597 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mh0sp-00028Z-St for grub-devel@gnu.org; Fri, 28 Aug 2009 08:48:47 -0400 Received: from xvm-190-8.ghst.net ([217.70.190.8]:59916 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Mh0sp-0007TF-C9 for grub-devel@gnu.org; Fri, 28 Aug 2009 08:48:47 -0400 Received: from [192.168.10.10] (helo=localhost) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1Mh0sn-0002Ur-T7 for grub-devel@gnu.org; Fri, 28 Aug 2009 14:48:46 +0200 Received: from rmh by localhost with local (Exim 4.69) (envelope-from ) id 1Mh0sn-0003wH-Cz for grub-devel@gnu.org; Fri, 28 Aug 2009 14:48:45 +0200 Date: Fri, 28 Aug 2009 14:48:45 +0200 From: Robert Millan To: grub-devel@gnu.org Message-ID: <20090828124845.GD15030@thorin> References: <20090826235518.GV11691@riva.ucam.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20090826235518.GV11691@riva.ucam.org> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: [PATCH] Compiler warning in grub_cmdline_get X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Aug 2009 12:48:57 -0000 On Thu, Aug 27, 2009 at 12:55:18AM +0100, Colin Watson wrote: > I don't think this can actually cause a real problem, but it's a > compiler warning since it might (e.g. if prompt ever contained "%"). > > /home/cjwatson/src/ubuntu/grub2/tmp/grub2-1.96+20090826/normal/cmdline.c: In function ‘grub_cmdline_get’: > /home/cjwatson/src/ubuntu/grub2/tmp/grub2-1.96+20090826/normal/cmdline.c:276: warning: format not a string literal and no format arguments > > 2009-08-27 Colin Watson > > * normal/cmdline.c (grub_cmdline_get): Supply a format string as > the first argument to grub_printf. Thanks Colin. For obvious fixes like this one, feel free to commit them right away. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."