From: Ivo van Doorn <ivdoorn@gmail.com>
To: users@rt2x00.serialmonkey.com
Cc: Benoit PAPILLAULT <benoit.papillault@free.fr>,
"linux-wireless" <linux-wireless@vger.kernel.org>
Subject: Re: [rt2x00-users] [PATCH] rt2x00: Reorganize padding & L2 padding
Date: Sun, 30 Aug 2009 15:32:47 +0200 [thread overview]
Message-ID: <200908301532.47769.IvDoorn@gmail.com> (raw)
In-Reply-To: <4A9990A8.1080002@free.fr>
> > +void rt2x00queue_remove_l2pad(struct sk_buff *skb, unsigned int
> > header_length) +{ + struct skb_frame_desc *skbdesc =
> > get_skb_frame_desc(skb); + unsigned int l2pad = 4 - (header_length
> > & 3);
> This formula is incorrect, it should be at least (4 -
> (header_length%4)%4). I have a fix in my pending patches...
> If header_length is 0 => l2pad should be 0 as well.
Header_length should never be 0 (that was fixed by this patch), so that should
not be a problem. I'll review your patch so it can be send as update later. But I
do think this patch can be merged into linux-wireless in regardless.
Ivo
P.S. Your mail client is really messing up the replies by removing end-of-line
characters. :S
next prev parent reply other threads:[~2009-08-30 13:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-29 18:30 [PATCH] rt2x00: Reorganize padding & L2 padding Ivo van Doorn
2009-08-29 20:33 ` [rt2x00-users] " Benoit PAPILLAULT
2009-08-30 13:32 ` Ivo van Doorn [this message]
2009-08-30 19:47 ` Benoit PAPILLAULT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200908301532.47769.IvDoorn@gmail.com \
--to=ivdoorn@gmail.com \
--cc=benoit.papillault@free.fr \
--cc=linux-wireless@vger.kernel.org \
--cc=users@rt2x00.serialmonkey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.