From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753877AbZH3Qeg (ORCPT ); Sun, 30 Aug 2009 12:34:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753859AbZH3Qef (ORCPT ); Sun, 30 Aug 2009 12:34:35 -0400 Received: from e23smtp05.au.ibm.com ([202.81.31.147]:38603 "EHLO e23smtp05.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753840AbZH3Qee (ORCPT ); Sun, 30 Aug 2009 12:34:34 -0400 Date: Sun, 30 Aug 2009 22:04:17 +0530 From: "Aneesh Kumar K.V" To: Catalin Marinas , Theodore Tso Cc: "Luis R. Rodriguez" , linux-kernel@vger.kernel.org, Greg Kroah-Hartman Subject: Re: memleaks, acpi + ext4 + tty Message-ID: <20090830163417.GA15183@skywalker.linux.vnet.ibm.com> References: <43e72e890908272225w79ec5bf6kc7ef1160e5a088ae@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 28, 2009 at 05:32:10PM +0100, Catalin Marinas wrote: > "Luis R. Rodriguez" wrote: > > I have an assorted collection of kmemleak reports for acpi, ext4 and > > tty, not sure how to read these yet to fix so figure I'd at least post > > them. To reproduce I can just dd=/dev/zero to some big file and played > > some video. > > If you do a few echo scan > /sys/kernel/debug/kmemleak, do they > disappear (i.e. transient false positives)? > > Which kernel version is this? > > > unreferenced object 0xffff88003e0015c0 (size 64): > > comm "swapper", pid 1, jiffies 4294892352 > > backtrace: > > [] create_object+0x13d/0x2d0 > > [] kmemleak_alloc+0x25/0x60 > > [] kmem_cache_alloc_node+0x193/0x200 > > [] process_zones+0x70/0x1cd > > [] pageset_cpuup_callback+0x35/0x92 > > [] notifier_call_chain+0x47/0x90 > > [] __raw_notifier_call_chain+0x9/0x10 > > [] _cpu_up+0x75/0x130 > > [] cpu_up+0x5a/0x6a > > [] kernel_init+0xcc/0x1ba > > [] child_rip+0xa/0x20 > > [] 0xffffffffffffffff > > Can't really tell. Maybe a false positive caused by kmemleak not > scanning the pgdata node_zones. Can you post your .config file? > > > unreferenced object 0xffff88003cb5f700 (size 64): > > comm "swapper", pid 1, jiffies 4294892459 > > backtrace: > > [] create_object+0x13d/0x2d0 > > [] kmemleak_alloc+0x25/0x60 > > [] __kmalloc+0x16b/0x250 > > [] kzalloc+0xf/0x11 > > [] acpi_add_single_object+0x58e/0xd3c > > [] acpi_bus_scan+0x125/0x1af > > [] acpi_scan_init+0xc8/0xe9 > > [] acpi_init+0x21f/0x265 > > [] do_one_initcall+0x4b/0x1b0 > > [] kernel_init+0x164/0x1ba > > [] child_rip+0xa/0x20 > > [] 0xffffffffffffffff > > I get ACPI reports as well and they may be real leaks. However, I > didn't have time to analyse the code (pretty complicated reference > counting). > > > unreferenced object 0xffff880039571800 (size 1024): > > comm "exe", pid 1168, jiffies 4294893410 > > backtrace: > > [] create_object+0x13d/0x2d0 > > [] kmemleak_alloc+0x25/0x60 > > [] __kmalloc+0x16b/0x250 > > [] ext4_mb_init+0x1a1/0x590 > > [] ext4_fill_super+0x1df3/0x26c0 > > [] get_sb_bdev+0x16f/0x1b0 > > [] ext4_get_sb+0x13/0x20 > > [] vfs_kern_mount+0x76/0x180 > > [] do_kern_mount+0x4d/0x130 > > [] do_mount+0x307/0x8b0 > > [] sys_mount+0x8f/0xe0 > > [] system_call_fastpath+0x16/0x1b > > [] 0xffffffffffffffff > > The ext4 reports are real leaks and patch was posted here - > http://lkml.org/lkml/2009/7/15/62. However, it hasn't been merged into > mainline yet (I cc'ed Aneesh). > The patch is part of ext4-patchqueue http://repo.or.cz/w/ext4-patch-queue.git Ted, Any plans to push the patches to linus tree soon ? -aneesh