From: Christoph Hellwig <hch@infradead.org>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: trond.myklebust@fys.uio.no, linux-nfs@vger.kernel.org
Subject: Re: [PATCH 1/5] NFS: combine nfs_kill_super() and nfs4_kill_super()
Date: Sun, 30 Aug 2009 12:42:29 -0400 [thread overview]
Message-ID: <20090830164229.GA32025@infradead.org> (raw)
In-Reply-To: <20090830163432.3652.437.stgit-RytpoXr2tKZ9HhUboXbp9zCvJB+x5qRC@public.gmane.org>
On Sun, Aug 30, 2009 at 12:34:33PM -0400, Chuck Lever wrote:
> +static void nfs_kill_super(struct super_block *sb)
> {
> + struct nfs_server *server = NFS_SB(sb);
> +
> + dprintk("--> %s\n", __func__);
> +
> +#ifdef CONFIG_NFS_V4
> + if (server->nfs_client->rpc_ops->version == 4) {
> + nfs_super_return_all_delegations(sb);
> + nfs4_renewd_prepare_shutdown(server);
> + }
> +#endif /* CONFIG_NFS_V4 */
>
> bdi_unregister(&server->backing_dev_info);
This was previously not done for nfs4. If it is a bug-fixed that
should be documented in the patch description, and if not it needs
to be changed.
next prev parent reply other threads:[~2009-08-30 16:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-30 16:34 [PATCH 0/5] Support "-t nfs,vers=4" mounts in the kernel Chuck Lever
[not found] ` <20090830162211.3652.14638.stgit-RytpoXr2tKZ9HhUboXbp9zCvJB+x5qRC@public.gmane.org>
2009-08-30 16:34 ` [PATCH 1/5] NFS: combine nfs_kill_super() and nfs4_kill_super() Chuck Lever
[not found] ` <20090830163432.3652.437.stgit-RytpoXr2tKZ9HhUboXbp9zCvJB+x5qRC@public.gmane.org>
2009-08-30 16:42 ` Christoph Hellwig [this message]
2009-08-30 16:59 ` Trond Myklebust
[not found] ` <1251651593.12486.14.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>
2009-08-30 17:04 ` Chuck Lever
2009-08-30 16:34 ` [PATCH 2/5] NFS: Mount option parser should detect unset port values Chuck Lever
2009-08-30 16:34 ` [PATCH 3/5] NFS: Refactor NFSv4 text-based mount option validation Chuck Lever
2009-08-30 16:34 ` [PATCH 4/5] NFS: Move details of nfs4_get_sb() to a helper Chuck Lever
2009-08-30 16:35 ` [PATCH 5/5] NFS: Allow the "nfs" file system type to support NFSv4 Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090830164229.GA32025@infradead.org \
--to=hch@infradead.org \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.