All of lore.kernel.org
 help / color / mirror / Atom feed
From: Theodore Tso <tytso@mit.edu>
To: "Luis R. Rodriguez" <mcgrof@gmail.com>
Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	linux-kernel@vger.kernel.org, Greg Kroah-Hartman <gregkh@suse.de>
Subject: Re: memleaks, acpi + ext4 + tty
Date: Sun, 30 Aug 2009 14:24:24 -0400	[thread overview]
Message-ID: <20090830182424.GB20822@mit.edu> (raw)
In-Reply-To: <43e72e890908301029t71a9c1a2t3d17e99cf3112ad2@mail.gmail.com>

On Sun, Aug 30, 2009 at 10:29:01AM -0700, Luis R. Rodriguez wrote:
> > Yes, as soon as the next merge window opens.  The leak only shows up
> > when you mount and unmount a filesystem, which under normal
> > circumstances doesn't happen a huge number of times on most systems.
> > By the time it showed up it was late enough in the 2.6.31-rcX series
> > that I figured it was better to wait until the next merge window.  I
> > didn't consider it a high priority bug.
> 
> That's odd I run into this kmemleak with a single bootup, no manual remounts.
> 

Yeah, but it's a singleton leak.  Let me be a bit more precise this
time: the leak happens at mount time because we're essentially doing
this due to some code that was accidentally duplicated when it was
being refactored:

	a = kmalloc(sizeof(...)*N, GFP_ATOMIC);
	  ...
	a = kmalloc(sizeof(...)*N, GFP_ATOMIC);

So a small amount of memory is leaked each time a filesystem is
mounted.  It doesn't become a huge problem unless you are repeatedly
mounting and unmounting the same filesystem in a tight loop.

	     		    	 	       	 - Ted

  reply	other threads:[~2009-08-30 18:24 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-28  5:25 memleaks, acpi + ext4 + tty Luis R. Rodriguez
2009-08-28 16:32 ` Catalin Marinas
2009-08-28 16:52   ` Luis R. Rodriguez
2009-08-28 21:50     ` Luis R. Rodriguez
2009-08-28 22:09       ` Luis R. Rodriguez
2009-08-31  8:23         ` Luis R. Rodriguez
2009-08-31 17:50           ` Luis R. Rodriguez
2009-08-31 18:37             ` Luis R. Rodriguez
2009-08-31 19:30               ` Luis R. Rodriguez
2009-08-31 19:33                 ` John W. Linville
2009-08-31 19:43                   ` Luis R. Rodriguez
2009-08-31 19:47                     ` John W. Linville
2009-08-31 20:02                       ` Luis R. Rodriguez
2009-08-31 23:54                         ` Luis R. Rodriguez
2009-09-01  0:26                           ` Eric Paris
2009-09-01  0:31                             ` Luis R. Rodriguez
2009-09-01  6:33                               ` Zhu Yi
2009-09-01 18:00                                 ` Luis R. Rodriguez
2009-08-31 19:58                     ` Luis R. Rodriguez
2009-09-01 22:10                       ` H. Peter Anvin
2009-08-29 21:41     ` Catalin Marinas
2009-08-30 16:34   ` Aneesh Kumar K.V
2009-08-30 17:17     ` Theodore Tso
2009-08-30 17:29       ` Luis R. Rodriguez
2009-08-30 18:24         ` Theodore Tso [this message]
2009-09-01 17:59           ` Luis R. Rodriguez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090830182424.GB20822@mit.edu \
    --to=tytso@mit.edu \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=catalin.marinas@arm.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mcgrof@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.