From: Jack Steiner <steiner@sgi.com>
To: Roel Kluin <roel.kluin@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] gru: allocation may fail in quicktest1()
Date: Mon, 31 Aug 2009 07:50:59 -0500 [thread overview]
Message-ID: <20090831125059.GA31874@sgi.com> (raw)
In-Reply-To: <4A9B8A8F.5020600@gmail.com>
On Mon, Aug 31, 2009 at 10:32:15AM +0200, Roel Kluin wrote:
> The allocation may fail.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Acked-by: Jack Steiner <steiner@sgi.com>
> ---
> diff --git a/drivers/misc/sgi-gru/grukservices.c b/drivers/misc/sgi-gru/grukservices.c
> index 79689b1..766e21e 100644
> --- a/drivers/misc/sgi-gru/grukservices.c
> +++ b/drivers/misc/sgi-gru/grukservices.c
> @@ -937,6 +937,8 @@ static int quicktest1(unsigned long arg)
>
> /* Need 1K cacheline aligned that does not cross page boundary */
> p = kmalloc(4096, 0);
> + if (p == NULL)
> + return -ENOMEM;
> mq = ALIGNUP(p, 1024);
> memset(mes, 0xee, sizeof(mes));
> dw = mq;
prev parent reply other threads:[~2009-08-31 12:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-31 8:32 [PATCH] gru: allocation may fail in quicktest1() Roel Kluin
2009-08-31 12:50 ` Jack Steiner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090831125059.GA31874@sgi.com \
--to=steiner@sgi.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.