All of lore.kernel.org
 help / color / mirror / Atom feed
From: Frans Pop <elendil@planet.nl>
To: Zhang Rui <rui.zhang@intel.com>
Cc: "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Thomas, Sujith" <sujith.thomas@intel.com>,
	Matthew Garrett <mjg59@srcf.ucam.org>
Subject: Re: [PATCH 2/6] thermal: sysfs-api.txt - document passive attribute for thermal zones
Date: Mon, 31 Aug 2009 13:19:58 +0200	[thread overview]
Message-ID: <200908311320.00632.elendil@planet.nl> (raw)
In-Reply-To: <1251706691.3483.169.camel@rzhang-dt>

On Monday 31 August 2009, Zhang Rui wrote:
> > +passive
> > +	Attribute is only present for zones which do not have a passive
> > +	cooling policy (_PSV) defined in ACPI.
>
> We should not involve any platform specific stuff in this
> documentation. how about "Attribute is only present for zones in which
> the passive cooling policy is not supported by native thermal driver"
[...]
> > -If the processor is listed in _PSL method, and the fan is listed in
> > _AL0 -method, the sys I/F structure will be built like this:
> > +If the processor is listed in _PSL method, the fan is listed in _AL0
> > +method, and the zone has a _PSV method, the sys I/F structure will
> > be +built like this:
>
> For an ACPI thermal zone, supporting passive cooling means that both
> _PSL and _PSV are available.
> so I don't think we need to change this. :)

OK. Updated patch below.


From: Frans Pop <elendil@planet.nl>
Subject: thermal: sysfs-api.txt - document passive attribute for thermal zones

Signed-off-by: Frans Pop <elendil@planet.nl>
Cc: Zhang Rui <rui.zhang@intel.com>
Cc: Sujith Thomas <sujith.thomas@intel.com>
Cc: Matthew Garrett <mjg59@srcf.ucam.org>

diff --git a/Documentation/thermal/sysfs-api.txt b/Documentation/thermal/sysfs-api.txt
index 895337f..a87dc27 100644
--- a/Documentation/thermal/sysfs-api.txt
+++ b/Documentation/thermal/sysfs-api.txt
@@ -199,6 +199,15 @@ cdev[0-*]_trip_point
 	point.
 	RO, Optional
 
+passive
+	Attribute is only present for zones in which the passive cooling
+	policy is not supported by native thermal driver. Default is zero
+	and can be set to a temperature (in millidegrees) to enable a
+	passive trip point for the zone. Activation is done by polling
+	with an interval of 1 second.
+	Unit: millidegrees Celsius
+	RW, Optional
+
 *****************************
 * Cooling device attributes *
 *****************************

  reply	other threads:[~2009-08-31 11:19 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-26 16:17 [PATCH 0/6] thermal: improvements re. forced passive cooling Frans Pop
2009-08-26 16:17 ` [PATCH 1/6] thermal: sysfs-api.txt - reformat for improved readability Frans Pop
2009-08-26 16:17 ` [PATCH 2/6] thermal: sysfs-api.txt - document passive attribute for thermal zones Frans Pop
2009-08-31  8:18   ` Zhang Rui
2009-08-31 11:19     ` Frans Pop [this message]
2009-09-01  0:44       ` Zhang Rui
2009-09-02 20:02         ` Pavel Machek
2009-09-03 14:34           ` Frans Pop
2009-08-26 16:17 ` [PATCH 3/6] acpi: thermal: display forced passive trip points in proc Frans Pop
2009-08-31  8:20   ` Zhang Rui
2009-08-26 16:17 ` [PATCH 4/6] thermal: add sanity check for the passive attribute Frans Pop
2009-08-26 16:23   ` Matthew Garrett
2009-08-26 16:48     ` Frans Pop
2009-08-26 16:48       ` Frans Pop
2009-08-31  8:33       ` Zhang Rui
2009-08-31  8:33         ` Zhang Rui
2009-08-31 10:30         ` Frans Pop
2009-08-31 10:30           ` Frans Pop
2009-09-03  6:10           ` Zhang Rui
2009-09-03  6:10             ` Zhang Rui
2009-09-03 14:33             ` [PATCH 4/6,v2] " Frans Pop
2009-09-03 14:33               ` Frans Pop
2009-08-26 16:17 ` [PATCH 5/6] thermal: Only set passive_delay for forced passive cooling Frans Pop
2009-08-26 16:25   ` Matthew Garrett
2009-09-10 16:07     ` Frans Pop
2009-09-10 16:15       ` Matthew Garrett
2009-08-26 16:17 ` [PATCH 6/6] thermal: disable polling if passive_delay and polling_delay are both unset Frans Pop
2009-08-26 16:25   ` Matthew Garrett
2009-09-11  6:08 ` [PATCH 0/6] thermal: improvements re. forced passive cooling Frans Pop
  -- strict thread matches above, loose matches on Subject: below --
2009-10-26  7:38 [PATCH 0/6] [resend] " Frans Pop
2009-10-26  7:39 ` [PATCH 2/6] thermal: sysfs-api.txt - document passive attribute for thermal zones Frans Pop
2009-11-05 23:11   ` Len Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200908311320.00632.elendil@planet.nl \
    --to=elendil@planet.nl \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjg59@srcf.ucam.org \
    --cc=rui.zhang@intel.com \
    --cc=sujith.thomas@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.