From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [PATCH] call vmx_load_host_state() only if msr is cached Date: Mon, 31 Aug 2009 11:04:27 -0300 Message-ID: <20090831140427.GA5234@amt.cnet> References: <20090827120730.GN30093@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: avi@redhat.com, kvm@vger.kernel.org To: Gleb Natapov Return-path: Received: from mx1.redhat.com ([209.132.183.28]:44061 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751196AbZHaOEn (ORCPT ); Mon, 31 Aug 2009 10:04:43 -0400 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n7VE4kqb011247 for ; Mon, 31 Aug 2009 10:04:46 -0400 Content-Disposition: inline In-Reply-To: <20090827120730.GN30093@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, Aug 27, 2009 at 03:07:30PM +0300, Gleb Natapov wrote: > No need to call it before each kvm_(set|get)_msr_common() > > Signed-off-by: Gleb Natapov > diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c > index 6b57eed..7494ef1 100644 > --- a/arch/x86/kvm/vmx.c > +++ b/arch/x86/kvm/vmx.c > @@ -1005,9 +1005,9 @@ static int vmx_get_msr(struct kvm_vcpu *vcpu, u32 msr_index, u64 *pdata) > data = vmcs_readl(GUEST_SYSENTER_ESP); > break; > default: > - vmx_load_host_state(to_vmx(vcpu)); > msr = find_msr_entry(to_vmx(vcpu), msr_index); > if (msr) { > + vmx_load_host_state(to_vmx(vcpu)); > data = msr->data; > break; > } > @@ -1064,9 +1064,9 @@ static int vmx_set_msr(struct kvm_vcpu *vcpu, u32 msr_index, u64 data) > } > /* Otherwise falls through to kvm_set_msr_common */ > default: > - vmx_load_host_state(vmx); > msr = find_msr_entry(vmx, msr_index); > if (msr) { > + vmx_load_host_state(vmx); All is needed here save_msrs(vmx->guest_msrs), right? Looks fine to me. Do you have any numbers or just notice it out of code review? > msr->data = data; > break; > } > -- > Gleb. > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html