From: Florian Fainelli <f.fainelli@gmail.com>
To: Roel Kluin <roel.kluin@gmail.com>
Cc: netdev@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] au1000_eth: possible NULL dereference of aup->mii_bus->irq in au1000_probe()
Date: Mon, 31 Aug 2009 14:38:55 +0200 [thread overview]
Message-ID: <200908311439.01781.f.fainelli@gmail.com> (raw)
In-Reply-To: <4A9B8C6F.3040503@gmail.com>
Hello Roel,
Le lundi 31 août 2009 10:40:15, Roel Kluin a écrit :
> aup->mii_bus->irq allocation may fail, prevent a dereference of NULL.
Good catch.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Acked-by: Florian Fainelli <florian@openwrt.org>
> ---
> diff --git a/drivers/net/au1000_eth.c b/drivers/net/au1000_eth.c
> index d3c734f..02e4be0 100644
> --- a/drivers/net/au1000_eth.c
> +++ b/drivers/net/au1000_eth.c
> @@ -1157,6 +1157,9 @@ static struct net_device * au1000_probe(int port_num)
> aup->mii_bus->name = "au1000_eth_mii";
> snprintf(aup->mii_bus->id, MII_BUS_ID_SIZE, "%x", aup->mac_id);
> aup->mii_bus->irq = kmalloc(sizeof(int)*PHY_MAX_ADDR, GFP_KERNEL);
> + if (aup->mii_bus->irq == NULL)
> + goto err_out;
> +
> for(i = 0; i < PHY_MAX_ADDR; ++i)
> aup->mii_bus->irq[i] = PHY_POLL;
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Cordialement, Florian Fainelli
------------------------------
next prev parent reply other threads:[~2009-08-31 12:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-31 8:40 [PATCH] au1000_eth: possible NULL dereference of aup->mii_bus->irq in au1000_probe() Roel Kluin
2009-08-31 12:38 ` Florian Fainelli [this message]
2009-09-02 0:45 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200908311439.01781.f.fainelli@gmail.com \
--to=f.fainelli@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.