From: Felipe Balbi <felipe.balbi@nokia.com>
To: "ext Guzman Lugo, Fernando" <x0095840@ti.com>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
"Balbi Felipe (Nokia-D/Helsinki)" <felipe.balbi@nokia.com>,
"Doyu Hiroshi (Nokia-D/Helsinki)" <hiroshi.doyu@nokia.com>,
"Palande Ameya (Nokia-D/Helsinki)" <ameya.palande@nokia.com>,
Linux OMAP Mailing List <linux-omap@vger.kernel.org>
Subject: Re: [DSPBRIGDE PATCH 6/6] dsp: bridge: beautify erro path
Date: Tue, 1 Sep 2009 00:54:01 +0300 [thread overview]
Message-ID: <20090831215401.GA30847@nokia.com> (raw)
In-Reply-To: <496565EC904933469F292DDA3F1663E602A5EF2E1F@dlee06.ent.ti.com>
Hi,
On Mon, Aug 31, 2009 at 09:50:30PM +0200, ext Guzman Lugo, Fernando wrote:
> >As far as I see this is not the dsp status but just a word to collect
> >errors. More logical in this piece of your code is to use result word
> >instead of status.
>
> Maybe you did not see far enough, but variable initStatus it the one use to
> store DSPBridge errors, the variable status is use to collect the status
> from calls to kernel functions. So I think we don't need two variables to
> collect error from kernel, so we should use one, it could be status or
> results it does not matters. What do you think?
yes, this has to be cleaned up, but it should be an extra patch and not
in this one.
--
balbi
next prev parent reply other threads:[~2009-08-31 21:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-21 10:23 [DSPBRIGDE PATCH 0/6] trivial dsp patches Felipe Balbi
2009-08-21 10:23 ` [DSPBRIGDE PATCH 1/6] dsp: bridge: use ARRAY_SIZE Felipe Balbi
2009-08-21 10:23 ` [DSPBRIGDE PATCH 2/6] dsp: bridge: wcd: else is unnecessary Felipe Balbi
2009-08-21 10:23 ` [DSPBRIGDE PATCH 3/6] dsp: bridge: rename Kbuild to Makefile Felipe Balbi
2009-08-21 10:23 ` [DSPBRIGDE PATCH 4/6] dsp: bridge: always use dynamic major/minor numbers Felipe Balbi
2009-08-21 10:23 ` [DSPBRIGDE PATCH 5/6] dsp: brigde: remove unnecessary memset() Felipe Balbi
2009-08-21 10:23 ` [DSPBRIGDE PATCH 6/6] dsp: bridge: beautify erro path Felipe Balbi
2009-08-28 20:58 ` Guzman Lugo, Fernando
2009-08-28 21:13 ` Andy Shevchenko
2009-08-28 22:31 ` Guzman Lugo, Fernando
2009-08-29 7:18 ` Andy Shevchenko
2009-08-31 19:50 ` Guzman Lugo, Fernando
2009-08-31 21:54 ` Felipe Balbi [this message]
2009-08-21 10:29 ` [DSPBRIGDE PATCH 5/6] dsp: brigde: remove unnecessary memset() Felipe Balbi
2009-08-28 20:55 ` Guzman Lugo, Fernando
2009-08-28 20:58 ` [DSPBRIGDE PATCH 4/6] dsp: bridge: always use dynamic major/minor numbers Guzman Lugo, Fernando
2009-08-31 20:10 ` [DSPBRIGDE PATCH 3/6] dsp: bridge: rename Kbuild to Makefile Guzman Lugo, Fernando
2009-08-28 20:57 ` [DSPBRIGDE PATCH 2/6] dsp: bridge: wcd: else is unnecessary Guzman Lugo, Fernando
2009-08-28 20:57 ` [DSPBRIGDE PATCH 1/6] dsp: bridge: use ARRAY_SIZE Guzman Lugo, Fernando
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090831215401.GA30847@nokia.com \
--to=felipe.balbi@nokia.com \
--cc=ameya.palande@nokia.com \
--cc=andy.shevchenko@gmail.com \
--cc=hiroshi.doyu@nokia.com \
--cc=linux-omap@vger.kernel.org \
--cc=x0095840@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.