Re: NFSD: Fix a bug in the NFSv4 'supported attrs' mandatory attribute

["J. Bruce Fields" <bfields@fieldses.org>]

On Mon, Aug 31, 2009 at 03:16:11PM -0400, Trond Myklebust wrote:
> From: Trond Myklebust <Trond.Myklebust@netapp.com>
> 
> The fact that the filesystem is present does _not_ imply that the
> fs_locations attribute should be marked as "unsupported".

Yes, but the fact that the filesystem is present also does not imply
that exp->ex_fslocs.locations is NULL.  So I'm confused by your
characterization of the existing code.

If you want to do this, you probably also want to turn off the previous
exfslocs.locations check in the same function.  Otherwise we claim
support for the attribute but then never actually return it.

--b.

> 
> Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
> ---
> 
>  fs/nfsd/nfs4xdr.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> 
> diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c
> index 2dcc7fe..1b07183 100644
> --- a/fs/nfsd/nfs4xdr.c
> +++ b/fs/nfsd/nfs4xdr.c
> @@ -1825,8 +1825,6 @@ nfsd4_encode_fattr(struct svc_fh *fhp, struct svc_export *exp,
>  			goto out_resource;
>  		if (!aclsupport)
>  			word0 &= ~FATTR4_WORD0_ACL;
> -		if (!exp->ex_fslocs.locations)
> -			word0 &= ~FATTR4_WORD0_FS_LOCATIONS;
>  		if (!word2) {
>  			WRITE32(2);
>  			WRITE32(word0);
> 
> -- 
> Trond Myklebust
> Linux NFS client maintainer
> 
> NetApp
> Trond.Myklebust@netapp.com
> www.netapp.com