All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 2/3] G1: Add a G1 syntax for parsing
Date: Tue, 01 Sep 2009 12:14:55 -0500	[thread overview]
Message-ID: <200909011214.56106.denkenz@gmail.com> (raw)
In-Reply-To: <20090830040708.GA28068@mycelium.queued.net>

[-- Attachment #1: Type: text/plain, Size: 525 bytes --]

Hi Andres,

> This is based on the generic_at parser, with unnecessary stuff removed.
>
> The G1 routinely screws up CRLFs, so the parser needs to account for
> that.  This parser ignores leading CRLFs (which is what reference-ril
> does as well), as well as trailing LFs (which are sometimes left out).
> CRs are used as end-of-message indicators.  Since we're not bothering
> tracking CRLFs, there's also no need for a GARBAGE state, or MULTILINE
> stuff.
> ---

This one looks fine to me.

Regards,
-Denis

      reply	other threads:[~2009-09-01 17:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-30  4:07 [PATCH 2/3] G1: Add a G1 syntax for parsing Andres Salomon
2009-09-01 17:14 ` Denis Kenzior [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200909011214.56106.denkenz@gmail.com \
    --to=denkenz@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.