All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 3/3] G1: Add G1-specific SMS support
Date: Tue, 01 Sep 2009 12:16:56 -0500	[thread overview]
Message-ID: <200909011216.56476.denkenz@gmail.com> (raw)
In-Reply-To: <20090830040718.GA28091@mycelium.queued.net>

[-- Attachment #1: Type: text/plain, Size: 685 bytes --]

Hi Andres,

> This is based on the atmodem SMS code, with lots of stuff dropped.
>
> The G1's modem advertises support for CNMI mode 2, but attempting to
> set that actually fails.  Instead, we _need_ to use mode 1.  Along
> those lines, CNMA doesn't appear to work properly, so we disable it
> and use CMTI rather than CMT for PDUs.  CDS notifications (for status
> notifications) are disabled completely.

So as we discussed on IRC, this one should really be rolled up into the 
generic_at sms driver, since the only change of substance is the cnmi mode 
selection specific to the g1.  We need a driver quirk system to be figured out 
first though.

Regards,
-Denis

      reply	other threads:[~2009-09-01 17:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-30  4:07 [PATCH 3/3] G1: Add G1-specific SMS support Andres Salomon
2009-09-01 17:16 ` Denis Kenzior [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200909011216.56476.denkenz@gmail.com \
    --to=denkenz@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.