From: Jens Axboe <jens.axboe@oracle.com>
To: Nikanth Karthikesan <knikanth@suse.de>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Allow changing max_sectors_kb above the default 512
Date: Tue, 1 Sep 2009 22:39:29 +0200 [thread overview]
Message-ID: <20090901203929.GI12579@kernel.dk> (raw)
In-Reply-To: <200909011815.45979.knikanth@suse.de>
On Tue, Sep 01 2009, Nikanth Karthikesan wrote:
> The patch "block: Use accessor functions for queue limits"
> (ae03bf639a5027d27270123f5f6e3ee6a412781d) changed queue_max_sectors_store()
> to use blk_queue_max_sectors() instead of directly assigning the value.
>
> But blk_queue_max_sectors() differs a bit
> 1. It sets both max_sectors_kb, and max_hw_sectors_kb
> 2. Never allows one to change max_sectors_kb above BLK_DEF_MAX_SECTORS. If one
> specifies a value greater then max_hw_sectors is set to that value but
> max_sectors is set to BLK_DEF_MAX_SECTORS
>
> I am not sure whether blk_queue_max_sectors() should be changed, as it seems
> to be that way for a long time. And there may be callers dependent on that
> behaviour.
>
> This patch simply reverts to the older way of directly assigning the value to
> max_sectors as it was before.
>
> Signed-off-by: Nikanth Karthikesan <knikanth@suse.de>
Good catch! Applied for 2.6.31.
--
Jens Axboe
prev parent reply other threads:[~2009-09-01 20:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-01 12:45 [PATCH] Allow changing max_sectors_kb above the default 512 Nikanth Karthikesan
2009-09-01 20:39 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090901203929.GI12579@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=knikanth@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.