From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MimAV-0002D7-Vl for mharc-grub-devel@gnu.org; Wed, 02 Sep 2009 05:30:20 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MimAT-0002AH-5E for grub-devel@gnu.org; Wed, 02 Sep 2009 05:30:17 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MimAO-00025W-00 for grub-devel@gnu.org; Wed, 02 Sep 2009 05:30:16 -0400 Received: from [199.232.76.173] (port=43740 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MimAN-000254-JB for grub-devel@gnu.org; Wed, 02 Sep 2009 05:30:11 -0400 Received: from smarthost02.mail.zen.net.uk ([212.23.3.141]:49703) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MimAN-0006eR-8E for grub-devel@gnu.org; Wed, 02 Sep 2009 05:30:11 -0400 Received: from [82.69.40.219] (helo=riva.pelham.vpn.ucam.org) by smarthost02.mail.zen.net.uk with esmtp (Exim 4.63) (envelope-from ) id 1MimAM-0006ct-7v for grub-devel@gnu.org; Wed, 02 Sep 2009 09:30:10 +0000 Received: from cjwatson by riva.pelham.vpn.ucam.org with local (Exim 3.36 #1 (Debian)) for grub-devel@gnu.org id 1MimAL-0008L3-00; Wed, 02 Sep 2009 10:30:09 +0100 Date: Wed, 2 Sep 2009 10:30:09 +0100 From: Colin Watson To: The development of GRUB 2 Message-ID: <20090902093008.GQ13423@riva.ucam.org> References: <20090902090651.GN13423@riva.ucam.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) X-Originating-Smarthost02-IP: [82.69.40.219] X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: [PATCH] Some documentation updates X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Sep 2009 09:30:17 -0000 On Wed, Sep 02, 2009 at 11:13:19AM +0200, Vladimir 'phcoder' Serbinenko wrote: > On Wed, Sep 2, 2009 at 11:06 AM, Colin Watson wrote: > > I'm afraid I temporarily ran out of steam at this point, so there are > > still lots of commands to go, but here's a start. Does this look OK? > > > > 2009-09-02  Colin Watson   > > > >        * docs/grub.texi: Describe one-based partition numbering. > >        Document acpi, blocklist, crc, export, insmod, keystatus, ls, > >        set, and unset commands. > > Could you perhaps explicitly mention sections updated? Sure. > > -example is @samp{(hd0,0)/boot/grub/menu.lst}. This means the file > > +example is @samp{(hd0,1)/boot/grub/menu.lst}. This means the file > >  @file{/boot/grub/menu.lst} in the first partition of the first hard > > Please remove references to menu.lst. It's not wrong in this context > but still confusing OK. > Other than this patch is good. I don't think it needs more review. You > can commit it. All right, thanks. Committed. -- Colin Watson [cjwatson@ubuntu.com]