From: Jamie Lokier <jamie@shareable.org>
To: Marc Andre Tanner <mat@brain-dump.org>
Cc: linux-embedded@vger.kernel.org
Subject: Re: [PATCH 7/7] printk: provide a filtering macro for printk
Date: Wed, 2 Sep 2009 12:06:40 +0100 [thread overview]
Message-ID: <20090902110640.GA22602@shareable.org> (raw)
In-Reply-To: <20090902090313.GB2736@debbook.brain-dump.org>
Marc Andre Tanner wrote:
> Thanks, so if I understood it correctly this should be used like this:
>
> #define PRINTK_FILTER(fmt) ( \
> (((const char *)(fmt))[0] != '<' && CONFIG_PRINTK_VERBOSITY >= 4) || \
> (((const char *)(fmt))[0] == '<' && \
> ((const char *)(fmt))[1] <= *__stringify(CONFIG_PRINTK_VERBOSITY)) \
> )
>
> #define printk(fmt, ...) ({ \
> if (__builtin_constant_p(PRINTK_FILTER(fmt)) && PRINTK_FILTER(fmt)) \
> printk((fmt), ##__VA_ARGS__); \
> })
>
> The sizeof check wouldn't be necessary. Is this correct?
Looks good, except that I think kernel style is to use "do {...} while
(0)" rather than "({ ... })"
-- Jamie
next prev parent reply other threads:[~2009-09-02 11:06 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-01 22:31 [RFC|PATCH] Compile time printk verbosity Marc Andre Tanner
2009-09-01 22:31 ` [PATCH 1/7] printk: introduce CONFIG_PRINTK_VERBOSITY Marc Andre Tanner
2009-09-01 22:31 ` [PATCH 2/7] printk: move printk to the end of the file Marc Andre Tanner
2009-09-01 22:31 ` [PATCH 3/7] printk: introduce printk_unfiltered as an alias to printk Marc Andre Tanner
2009-09-01 22:31 ` [PATCH 4/7] drivers: replace printk with printk_unfiltered Marc Andre Tanner
2009-09-01 22:31 ` [PATCH 5/7] drivers: make macro independent of printk's return value Marc Andre Tanner
2009-09-01 22:31 ` [PATCH 6/7] video/stk-webcam: change use of STK_ERROR Marc Andre Tanner
2009-09-01 22:31 ` [PATCH 7/7] printk: provide a filtering macro for printk Marc Andre Tanner
2009-09-01 23:24 ` Tim Bird
2009-09-01 23:32 ` H Hartley Sweeten
2009-09-02 13:09 ` Marc Andre Tanner
2009-09-02 17:05 ` Tim Bird
2009-09-02 17:31 ` Tim Bird
2009-09-02 18:22 ` H Hartley Sweeten
2009-09-02 18:22 ` H Hartley Sweeten
2009-09-04 14:05 ` Marc Andre Tanner
2009-09-10 9:22 ` Geert Uytterhoeven
2009-09-01 23:35 ` Jamie Lokier
2009-09-02 9:03 ` Marc Andre Tanner
2009-09-02 9:54 ` Marc Andre Tanner
2009-09-02 11:06 ` Jamie Lokier [this message]
2009-09-02 12:25 ` Bill Gatliff
2009-09-02 12:44 ` Marc Andre Tanner
2009-09-02 12:54 ` Mike Frysinger
2009-09-02 14:07 ` Marc Andre Tanner
2009-09-02 14:30 ` Jamie Lokier
2009-09-01 23:37 ` [RFC|PATCH] Compile time printk verbosity Mike Frysinger
2009-09-02 8:57 ` Marc Andre Tanner
2009-09-02 9:11 ` Mike Frysinger
2009-09-02 9:47 ` Marc Andre Tanner
2009-09-02 9:56 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090902110640.GA22602@shareable.org \
--to=jamie@shareable.org \
--cc=linux-embedded@vger.kernel.org \
--cc=mat@brain-dump.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.