From: Ingo Molnar <mingo@elte.hu>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Peter Zijlstra <peterz@infradead.org>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
Subject: Re: linux-next: tip tree build warnings
Date: Thu, 3 Sep 2009 10:38:44 +0200 [thread overview]
Message-ID: <20090903083844.GA9912@elte.hu> (raw)
In-Reply-To: <20090903182510.8fd4d4d1.sfr@canb.auug.org.au>
* Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi all,
>
> Today's linux-next build (powerpc ppc64_defconfig) produced these warning:
>
> In file included from include/trace/ftrace.h:285,
> from include/trace/define_trace.h:61,
> from include/trace/events/timer.h:342,
> from kernel/timer.c:50:
> include/trace/events/timer.h: In function 'ftrace_raw_output_itimer_state':
> include/trace/events/timer.h:280: warning: format '%lu' expects type 'long unsigned int', but argument 4 has type 'cputime_t'
> include/trace/events/timer.h: In function 'ftrace_raw_output_itimer_expire':
> include/trace/events/timer.h:317: warning: format '%lu' expects type 'long unsigned int', but argument 5 has type 'cputime_t'
Should be harmless with no runtime effects - the fix would be to
harmonize the cputime_t types across architectures.
> Introduced by commit 3f0a525ebf4b8ef041a332bbe4a73aee94bb064b ("timers: Add tracepoints for itimer") from the tip tree.
>
> cputime_t is variously "u64", "unsigned long long" and "unsigned
> long" on different architectures.
Should be unsigned long i think. Most architectures use it as
unsigned long via include/asm-generic/cputime.h, except these three:
arch/ia64/include/asm/cputime.h:typedef u64 cputime_t;
arch/powerpc/include/asm/cputime.h:typedef u64 cputime_t;
arch/s390/include/asm/cputime.h:typedef unsigned long long cputime_t;
Or we could eliminate the type altogether as well and standardize on
u64. Thomas?
Ingo
next prev parent reply other threads:[~2009-09-03 8:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-03 8:25 linux-next: tip tree build warnings Stephen Rothwell
2009-09-03 8:38 ` Ingo Molnar [this message]
2009-09-03 12:13 ` Heiko Carstens
2009-09-03 12:24 ` Heiko Carstens
2009-09-07 8:59 ` Martin Schwidefsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090903083844.GA9912@elte.hu \
--to=mingo@elte.hu \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
--cc=xiaoguangrong@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.