All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
To: Greg KH <gregkh@suse.de>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: [PATCH] Fix missing include file in RTL8192U staging driver
Date: Thu, 3 Sep 2009 17:22:13 +0530	[thread overview]
Message-ID: <20090903115213.GA4315@linux.vnet.ibm.com> (raw)

Hi Greg,

	2.6.31-rc8 build fails with

drivers/staging/rtl8192su/r8192U_core.c:5086: error: implicit declaration of function 'vmalloc'
drivers/staging/rtl8192su/r8192U_core.c:5086: warning: cast to pointer from integer of different size
drivers/staging/rtl8192su/r8192U_core.c: In function 'rtl8192_usb_disconnect':
drivers/staging/rtl8192su/r8192U_core.c:12308: error: implicit declaration of function 'vfree'

Including the vmalloc.h file, fixes the build failure. I have tested the
patch for build failure only.

Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
--
 drivers/staging/rtl8192su/r8192U_core.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/staging/rtl8192su/r8192U_core.c b/drivers/staging/rtl8192su/r8192U_core.c
index 70f81a8..0734fec 100644
--- a/drivers/staging/rtl8192su/r8192U_core.c
+++ b/drivers/staging/rtl8192su/r8192U_core.c
@@ -75,6 +75,7 @@ double __extendsfdf2(float a) {return a;}
 #include "r8192U_dm.h"
 //#include "r8192xU_phyreg.h"
 #include <linux/usb.h>
+#include <linux/vmalloc.h>
 // FIXME: check if 2.6.7 is ok
 #if (LINUX_VERSION_CODE < KERNEL_VERSION(2,6,7))
 #define usb_kill_urb usb_unlink_urb
@@ -102,6 +103,7 @@ double __extendsfdf2(float a) {return a;}
 #include "r8192U_dm.h"
 //#include "r8192xU_phyreg.h"
 #include <linux/usb.h>
+#include <linux/vmalloc.h>
 // FIXME: check if 2.6.7 is ok
 #if (LINUX_VERSION_CODE < KERNEL_VERSION(2,6,7))
 #define usb_kill_urb usb_unlink_urb
			
			Kamalesh

             reply	other threads:[~2009-09-03 11:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-03 11:52 Kamalesh Babulal [this message]
2009-09-03 18:04 ` [PATCH] Fix missing include file in RTL8192U staging driver Greg KH
2009-09-04  5:21   ` Kamalesh Babulal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090903115213.GA4315@linux.vnet.ibm.com \
    --to=kamalesh@linux.vnet.ibm.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.