From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Egger Subject: Re: RE: [PATCH] Don't free irqaction for com irq when release irq. Date: Thu, 3 Sep 2009 12:04:52 +0200 Message-ID: <200909031204.53521.Christoph.Egger@amd.com> References: <706158FABBBA044BAD4FE898A02E4BC201C43C4D4E@pdsmsx503.ccr.corp.intel.com> <706158FABBBA044BAD4FE898A02E4BC201C43C4F67@pdsmsx503.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <706158FABBBA044BAD4FE898A02E4BC201C43C4F67@pdsmsx503.ccr.corp.intel.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com Cc: Keir Fraser , "Zhang, Xiantao" List-Id: xen-devel@lists.xenproject.org On Thursday 03 September 2009 11:38:35 Zhang, Xiantao wrote: > No, host S3 issue is caused by ioapic suspend/resume in dom0. IMO, dom0 > shouldn't perform S3 for ioapic , right ? dom0 initializes and programs ioapic. In short: ioapic is under control of dom0. Please explain why dom0 shouldn't do ioapic suspend/resume. Christoph > After fixing that issue, domain > S3 works well. Xiantao > > -----Original Message----- > From: Keir Fraser [mailto:keir.fraser@eu.citrix.com] > Sent: Thursday, September 03, 2009 2:14 PM > To: Zhang, Xiantao; Xen > Subject: Re: [PATCH] Don't free irqaction for com irq when release irq. > > On 03/09/2009 05:14, "Zhang, Xiantao" wrote: > > # HG changeset patch > > # User root@localhost.localdomain > > # Date 1251916103 14400 > > # Node ID 49e847aed58dde35f8a0f909999d01d97be6f531 > > # Parent 3b7cbf32fee909d860daacf70b8c3b97eaf036b5 > > x86: com devices's irqaction shouldn't free. > > > > Since irqs of serial devices are initialized in early Xen and > > its irqaction is not allocated from heap, so doesn't need free > > in release irq logic. > > Signed-off-by: Xiantao Zhang > > Does this fix host S3? > > -- Keir > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Andrew Bowd, Thomas M. McCoy, Giuliano Meroni Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632