From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MjDIk-0006bv-0b for mharc-grub-devel@gnu.org; Thu, 03 Sep 2009 10:28:38 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MjDIi-0006bi-QU for grub-devel@gnu.org; Thu, 03 Sep 2009 10:28:36 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MjDId-0006al-Kx for grub-devel@gnu.org; Thu, 03 Sep 2009 10:28:36 -0400 Received: from [199.232.76.173] (port=33121 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MjDId-0006ai-Cx for grub-devel@gnu.org; Thu, 03 Sep 2009 10:28:31 -0400 Received: from smarthost01.mail.zen.net.uk ([212.23.3.140]:45145) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MjDIc-0004sI-Pj for grub-devel@gnu.org; Thu, 03 Sep 2009 10:28:31 -0400 Received: from [82.69.40.219] (helo=riva.pelham.vpn.ucam.org) by smarthost01.mail.zen.net.uk with esmtp (Exim 4.63) (envelope-from ) id 1MjDIb-0003G3-C6 for grub-devel@gnu.org; Thu, 03 Sep 2009 14:28:29 +0000 Received: from cjwatson by riva.pelham.vpn.ucam.org with local (Exim 3.36 #1 (Debian)) for grub-devel@gnu.org id 1MjDIa-0005CD-00; Thu, 03 Sep 2009 15:28:28 +0100 Date: Thu, 3 Sep 2009 15:28:28 +0100 From: Colin Watson To: The development of GRUB 2 Message-ID: <20090903142828.GX13423@riva.ucam.org> References: <20090901161951.GK13423@riva.ucam.org> <20090903141627.GA6656@thorin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090903141627.GA6656@thorin> User-Agent: Mutt/1.5.18 (2008-05-17) X-Originating-Smarthost01-IP: [82.69.40.219] X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: [PATCH] Filename default for grub-editenv X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Sep 2009 14:28:37 -0000 On Thu, Sep 03, 2009 at 04:16:27PM +0200, Robert Millan wrote: > On Tue, Sep 01, 2009 at 05:19:51PM +0100, Colin Watson wrote: > > (Per a discussion with Robert on IRC, this can be post-1.97 if you > > like.) > > > > Would it make sense for grub-editenv to have a default for the filename? > > I dislike hardcoding something in package maintainer scripts that needs > > to match a #define. The interface would be a little awkward since it's > > grub-editenv FILENAME COMMAND, but we could just say that if you provide > > only one argument then we use the default filename. > > OK after 1.97 is out. Btw, please include a ChangeLog entry next time. I didn't? Bah, I could have sworn I had ... 2009-09-01 Colin Watson * util/grub-editenv.c (main): If only a command is given, use DEFAULT_DIRECTORY "/" GRUB_ENVBLK_DEFCFG as a default file name. (usage): FILENAME is now optional and has a default. -- Colin Watson [cjwatson@ubuntu.com]