From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Brownell Subject: Re: [PATCH 2/3] ASoC: DaVinci: pcm, rename variables in prep for ping/pong Date: Thu, 3 Sep 2009 14:36:01 -0700 Message-ID: <200909031436.01913.david-b@pacbell.net> References: <1251761505-11353-1-git-send-email-troy.kisky@boundarydevices.com> <200909031206.21020.david-b@pacbell.net> <4AA017EA.8080006@boundarydevices.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from smtp104.sbc.mail.gq1.yahoo.com (smtp104.sbc.mail.gq1.yahoo.com [67.195.15.63]) by alsa0.perex.cz (Postfix) with SMTP id C031B10383B for ; Thu, 3 Sep 2009 23:36:03 +0200 (CEST) In-Reply-To: <4AA017EA.8080006@boundarydevices.com> Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Troy Kisky Cc: davinci-linux-open-source@linux.davincidsp.com, alsa-devel@alsa-project.org, broonie@sirena.org.uk List-Id: alsa-devel@alsa-project.org On Thursday 03 September 2009, Troy Kisky wrote: > David Brownell wrote: > > On Monday 31 August 2009, Troy Kisky wrote: > >> - int master_lch; /* Master DMA channel */ > >> - int slave_lch; /* linked parameter RAM reload slot */ > >> + int asp_master_lch; /* Master DMA channel */ > >> + int asp_link_lch[2]; /* asp parameter link channel, ping/pong */ > > > > If you're going to rename things, may I suggest getting > > rid of "lch" ... use either "channel" or "link", since > > those are the two basic hardware roles in EDMA. > > I agree, but can that be a separate patch... However you like; I'd just suggest that *one* rename-things patch is normally preferred. If this one's already in the merge queue that might be awkward.