From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MjDgB-0006CL-UX for mharc-grub-devel@gnu.org; Thu, 03 Sep 2009 10:52:51 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MjDgA-0006Bh-77 for grub-devel@gnu.org; Thu, 03 Sep 2009 10:52:50 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MjDg5-00068S-H1 for grub-devel@gnu.org; Thu, 03 Sep 2009 10:52:49 -0400 Received: from [199.232.76.173] (port=33139 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MjDg5-00068J-CM for grub-devel@gnu.org; Thu, 03 Sep 2009 10:52:45 -0400 Received: from smarthost02.mail.zen.net.uk ([212.23.3.141]:56064) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MjDg4-0002pV-SR for grub-devel@gnu.org; Thu, 03 Sep 2009 10:52:45 -0400 Received: from [82.69.40.219] (helo=riva.pelham.vpn.ucam.org) by smarthost02.mail.zen.net.uk with esmtp (Exim 4.63) (envelope-from ) id 1MjDg3-0003j7-Uw for grub-devel@gnu.org; Thu, 03 Sep 2009 14:52:44 +0000 Received: from cjwatson by riva.pelham.vpn.ucam.org with local (Exim 3.36 #1 (Debian)) for grub-devel@gnu.org id 1MjDg3-0005Rj-00; Thu, 03 Sep 2009 15:52:43 +0100 Date: Thu, 3 Sep 2009 15:52:43 +0100 From: Colin Watson To: The development of GRUB 2 Message-ID: <20090903145243.GZ13423@riva.ucam.org> References: <20090902110141.GR13423@riva.ucam.org> <20090903143323.GH6656@thorin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090903143323.GH6656@thorin> User-Agent: Mutt/1.5.18 (2008-05-17) X-Originating-Smarthost02-IP: [82.69.40.219] X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: [PATCH] save_env variable_name=value X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Sep 2009 14:52:50 -0000 On Thu, Sep 03, 2009 at 04:33:23PM +0200, Robert Millan wrote: > On Wed, Sep 02, 2009 at 12:01:42PM +0100, Colin Watson wrote: > > 2009-09-02 Colin Watson > > > > * commands/loadenv.c (grub_cmd_save_env): Allow an optional > > explicit value (`save_env variable_name=value'). > > (GRUB_MOD_INIT (loadenv)): Update save_env summary. > > Maybe it is better to handle the extra logic at grub-mkconfig level > (for smaller/faster loadenv code). Is this feasible? It's feasible either way; I just did this because Pavel seemed to prefer it ... -- Colin Watson [cjwatson@ubuntu.com]