From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MjDvx-0007Gc-Vc for mharc-grub-devel@gnu.org; Thu, 03 Sep 2009 11:09:10 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MjDvw-0007FK-93 for grub-devel@gnu.org; Thu, 03 Sep 2009 11:09:08 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MjDvr-00079n-JK for grub-devel@gnu.org; Thu, 03 Sep 2009 11:09:07 -0400 Received: from [199.232.76.173] (port=44205 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MjDvr-00079L-F5 for grub-devel@gnu.org; Thu, 03 Sep 2009 11:09:03 -0400 Received: from xvm-190-8.ghst.net ([217.70.190.8]:50073 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MjDvp-00064I-Nw; Thu, 03 Sep 2009 11:09:01 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1MjDvo-0005C4-5o; Thu, 03 Sep 2009 17:09:00 +0200 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1MjDvn-0004lc-Ji; Thu, 03 Sep 2009 17:08:59 +0200 Date: Thu, 3 Sep 2009 17:08:59 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090903150859.GA18316@thorin> References: <20090902110141.GR13423@riva.ucam.org> <20090903143323.GH6656@thorin> <20090903145243.GZ13423@riva.ucam.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090903145243.GZ13423@riva.ucam.org> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Cc: Pavel Roskin Subject: Re: [PATCH] save_env variable_name=value X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Sep 2009 15:09:08 -0000 On Thu, Sep 03, 2009 at 03:52:43PM +0100, Colin Watson wrote: > On Thu, Sep 03, 2009 at 04:33:23PM +0200, Robert Millan wrote: > > On Wed, Sep 02, 2009 at 12:01:42PM +0100, Colin Watson wrote: > > > 2009-09-02 Colin Watson > > > > > > * commands/loadenv.c (grub_cmd_save_env): Allow an optional > > > explicit value (`save_env variable_name=value'). > > > (GRUB_MOD_INIT (loadenv)): Update save_env summary. > > > > Maybe it is better to handle the extra logic at grub-mkconfig level > > (for smaller/faster loadenv code). Is this feasible? > > It's feasible either way; I just did this because Pavel seemed to prefer > it ... Pavel, please comment on this when you can. It seems to me that doing it in grub-mkconfig would require less ad-hoc code in loadenv.mod and make it more efficient. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."