From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MjEro-00033V-5U for mharc-grub-devel@gnu.org; Thu, 03 Sep 2009 12:08:56 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MjErm-000314-5u for grub-devel@gnu.org; Thu, 03 Sep 2009 12:08:54 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MjErk-0002y4-9w for grub-devel@gnu.org; Thu, 03 Sep 2009 12:08:53 -0400 Received: from [199.232.76.173] (port=47078 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MjErk-0002xs-0r for grub-devel@gnu.org; Thu, 03 Sep 2009 12:08:52 -0400 Received: from ip1-68.bon.riksnet.se ([77.110.8.68]:4733 helo=micha.ume.nu) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MjErj-0001ad-Eo for grub-devel@gnu.org; Thu, 03 Sep 2009 12:08:51 -0400 Received: from localhost (micha.ume.nu [127.0.0.1]) by micha.ume.nu (Postfix) with ESMTP id D85DF14938 for ; Thu, 3 Sep 2009 19:23:08 +0200 (CEST) X-Virus-Scanned: amavisd-new at ume.nu Received: from micha.ume.nu ([127.0.0.1]) by localhost (micha.ume.nu [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Pp3FKCrRACrw for ; Thu, 3 Sep 2009 19:22:50 +0200 (CEST) Received: from laptop1.localnet (ip1-67.bon.riksnet.se [77.110.8.67]) by micha.ume.nu (Postfix) with ESMTP id AFAD81499F for ; Thu, 3 Sep 2009 19:22:50 +0200 (CEST) From: Magnus Granberg Organization: Ume.nu To: grub-devel@gnu.org Date: Thu, 3 Sep 2009 18:55:15 +0200 User-Agent: KMail/1.12.0 (Linux/2.6.30-gentoo-r5; KDE/4.3.0; x86_64; ; ) MIME-Version: 1.0 Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Message-Id: <200909031855.15975.zorry@ume.nu> X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] Some distributions ship compilers that include -fPIE in the default specs (Gentoo Hardened) X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Sep 2009 16:08:54 -0000 >On Thu, Sep 03, 2009 at 12:31:57AM +0200, Magnus Granberg wrote: >> >Why not just check if the compiler accepts -fno-PIE and use it? No >> >harm done if -fPIE wasn't default, right? >> ------ >> Didn't want to add -fno-PIE when it was not needed and to be on the >> safe side . I can make it to check for -fno-PIE and use that. > >First approach was fine IMHO. But please include a ChangeLog entry. > >-- >Robert Millan > > The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and > how) you may access your data; but nobody's threatening your freedom: we > still allow you to remove your data and not access it at all." The ChangeLog ----- 2009-09-03 Magnus Granberg * aclocal.m4: Add grub_CHECK_PIE. It check if the compiler include -fPIE in the default specs. * configure.ac: Check if pie_possible is yes and add -fno-PIE to TARGET_CFLAGS. ------ Hardened-Development /Magnus Granberg (Zorry)