All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Luis R. Rodriguez" <lrodriguez@atheros.com>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: Luis Rodriguez <Luis.Rodriguez@atheros.com>,
	"torvalds@linux-foundation.org" <torvalds@linux-foundation.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"penberg@cs.helsinki.fi" <penberg@cs.helsinki.fi>,
	"mcgrof@gmail.com" <mcgrof@gmail.com>
Subject: Re: [PATCH v2 2/5] kmemleak: add clear command support
Date: Fri, 4 Sep 2009 13:26:53 -0700	[thread overview]
Message-ID: <20090904202653.GE4949@mosca> (raw)
In-Reply-To: <1251996731.22485.25.camel@pc1117.cambridge.arm.com>

On Thu, Sep 03, 2009 at 09:52:11AM -0700, Catalin Marinas wrote:
> On Thu, 2009-09-03 at 01:35 -0400, Luis R. Rodriguez wrote:
> > In an ideal world your kmemleak output will be small,
> > when its not you can use the clear command to ingore previously
> > annotated kmemleak objects. We do this by painting them black.
> 
> Making the objects "black" means that they are completely ignored by
> kmemleak and they are assumed not to contain any valid references.
> Therefore they won't be scanned and many of the newly allocated objects
> would be false positives.

Got it, BTW can you elaborate as to why painting objects black would
create false positives for newly allocated objects? I fail to understand
why.

> You may want to make them "gray" and only those which were reported as
> unreferenced, something like below:
> 
>         if ((object->flags & OBJECT_REPORTED) && unreferenced_object(object))
>                 make_gray_object(object->pointer)

Thanks, will use this.

  Luis

  reply	other threads:[~2009-09-04 20:26 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-03  5:35 [PATCH v2 0/5] kmemleak: few small cleanups and clear command support Luis R. Rodriguez
2009-09-03  5:35 ` [PATCH v2 1/5] kmemleak: use bool for true/false questions Luis R. Rodriguez
2009-09-03  5:35 ` [PATCH v2 2/5] kmemleak: add clear command support Luis R. Rodriguez
2009-09-03 16:52   ` Catalin Marinas
2009-09-04 20:26     ` Luis R. Rodriguez [this message]
2009-09-04 22:28       ` Catalin Marinas
2009-09-03  5:35 ` [PATCH v2 3/5] kmemleak: move common painting code together Luis R. Rodriguez
2009-09-03  5:35 ` [PATCH v2 4/5] kmemleak: fix sparse warning over overshadowed flags Luis R. Rodriguez
2009-09-03 16:55   ` Catalin Marinas
2009-09-03 18:05     ` Luis R. Rodriguez
2009-09-03  5:35 ` [PATCH v2 5/5] kmemleak: fix sparse warning for static declarations Luis R. Rodriguez
2009-09-03  6:01 ` [PATCH v2 0/5] kmemleak: few small cleanups and clear command support Pekka Enberg
2009-09-03  8:30 ` Catalin Marinas
2009-09-04 19:57   ` Luis R. Rodriguez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090904202653.GE4949@mosca \
    --to=lrodriguez@atheros.com \
    --cc=Luis.Rodriguez@atheros.com \
    --cc=catalin.marinas@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mcgrof@gmail.com \
    --cc=penberg@cs.helsinki.fi \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.