From: Andrey Borzenkov <arvidjaar@mail.ru>
To: linux-hotplug@vger.kernel.org
Subject: Re: [PATCH] fix buffer overflow in util_run_program()
Date: Sat, 05 Sep 2009 04:34:11 +0000 [thread overview]
Message-ID: <200909050834.11329.arvidjaar@mail.ru> (raw)
In-Reply-To: <20090904195414.GS4363@florz.florz.dyndns.org>
[-- Attachment #1: Type: Text/Plain, Size: 713 bytes --]
On Saturday 05 of September 2009 08:25:01 Florian Zumbiehl wrote:
> Hi,
>
> > > diff --git a/libudev/libudev-util-private.c
> > > b/libudev/libudev-util-private.c index 64203a8..c309945 100644
> > > --- a/libudev/libudev-util-private.c
> > > +++ b/libudev/libudev-util-private.c
> > > @@ -268,7 +268,7 @@ int util_run_program(struct udev *udev, const
> > > char *command, char **envp, pid_t pid;
> > > char arg[UTIL_PATH_SIZE];
> > > char program[UTIL_PATH_SIZE];
> > > - char *argv[(sizeof(arg) / 2) + 1];
> > > + char *argv[sizeof(arg) + 1];
> >
> > Could you give example when this overflows?
>
> UTIL_PATH_SIZE-1 spaces.
>
Please try to understand what code you are fixing does.
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2009-09-05 4:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-04 19:54 [PATCH] fix buffer overflow in util_run_program() Florian Zumbiehl
2009-09-05 3:29 ` Andrey Borzenkov
2009-09-05 4:25 ` Florian Zumbiehl
2009-09-05 4:34 ` Andrey Borzenkov [this message]
2009-09-05 4:49 ` Florian Zumbiehl
2009-09-05 10:50 ` Alan Jenkins
2009-09-05 17:21 ` Florian Zumbiehl
2009-09-05 18:41 ` Alan Jenkins
2009-09-05 19:07 ` Andrey Borzenkov
2009-09-05 20:39 ` Florian Zumbiehl
2009-09-06 16:34 ` Kay Sievers
2009-09-07 18:18 ` [PATCH] fix buffer overflow in util_run_program(), #2 Florian Zumbiehl
2009-09-08 19:43 ` Kay Sievers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200909050834.11329.arvidjaar@mail.ru \
--to=arvidjaar@mail.ru \
--cc=linux-hotplug@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.