From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Mk2m5-0005Ha-MA for mharc-grub-devel@gnu.org; Sat, 05 Sep 2009 17:26:21 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mk2m4-0005HK-Cw for grub-devel@gnu.org; Sat, 05 Sep 2009 17:26:20 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mk2lz-0005Gw-Kw for grub-devel@gnu.org; Sat, 05 Sep 2009 17:26:19 -0400 Received: from [199.232.76.173] (port=43077 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mk2lz-0005Gt-HP for grub-devel@gnu.org; Sat, 05 Sep 2009 17:26:15 -0400 Received: from xvm-190-8.ghst.net ([217.70.190.8]:36688 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Mk2lz-00070y-3q for grub-devel@gnu.org; Sat, 05 Sep 2009 17:26:15 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1Mk2lw-0006TT-4B for grub-devel@gnu.org; Sat, 05 Sep 2009 23:26:12 +0200 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1Mk2lv-0003uq-DW for grub-devel@gnu.org; Sat, 05 Sep 2009 23:26:11 +0200 Date: Sat, 5 Sep 2009 23:26:11 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090905212611.GA15045@thorin> References: <20090901160704.GB27042@thorin> <20090903145854.GL6656@thorin> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: Require at least gcc 4.2 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Sep 2009 21:26:20 -0000 On Sat, Sep 05, 2009 at 11:01:32PM +0200, Vladimir 'phcoder' Serbinenko wrote: > On Thu, Sep 3, 2009 at 4:58 PM, Robert Millan wrote: > > On Tue, Sep 01, 2009 at 06:07:04PM +0200, Robert Millan wrote: > >> On Tue, Sep 01, 2009 at 03:44:18PM +0200, Vladimir 'phcoder' Serbinenko wrote: > >> > > >> > +AC_CACHE_CHECK([whether gcc is recent enough], grub_cv_cc_recent, [ > >> > +  CFLAGS= > >> > +  AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[ > >> > +#if defined (__GNUC__) && (__GNUC__ < 4 || __GNUC_MINOR__ < 2) > >> > +#error Use at least GCC 4.2 > >> > +#endif > >> > >> This would fail with e.g. GCC 5.0.  Other than this, the patch is fine. > >> > >> If Bean wants to add a configure option (e.g. like QEMU's --disable-gcc-check) > >> so that this requirement can be overriden, that's ok too. > > > > Btw, INSTALL file still says 2.95.  If we do this, it should be adjusted as > > well. > > > Cosidering recent gcc's still have nested function bug I consider > forcing 4.2 is absolutely unnecessary. > However INSTALL needs to be upgraded and mention a newer GCC since > grub2 isn't compileable with gcc 2.95 David et al, can we agree on a minimal version of GCC that we should recommend? For mentioning in the INSTALL file only. I assume nobody's interested in gcc 2.95. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."