From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gleb Natapov Subject: Re: [PATCH] fix userspace irqchip. Date: Sun, 6 Sep 2009 11:50:03 +0300 Message-ID: <20090906085003.GB27325@redhat.com> References: <1252021260-28941-1-git-send-email-glommer@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, avi@redhat.com To: Glauber Costa Return-path: Received: from mx1.redhat.com ([209.132.183.28]:11803 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753030AbZIFIuE (ORCPT ); Sun, 6 Sep 2009 04:50:04 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n868o65v008095 for ; Sun, 6 Sep 2009 04:50:06 -0400 Content-Disposition: inline In-Reply-To: <1252021260-28941-1-git-send-email-glommer@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, Sep 03, 2009 at 07:41:00PM -0400, Glauber Costa wrote: > It is broken since main loop reorganization. (6185d8b6) > What is broken? Boots WindowsXp for me here. > Problem is that we, the emulator, has nothing to do with the CPU flags. has_work() > should not depend on that at all. IF_MASK flags is set into env->eflags on each exit by function just above kvm_arch_has_work() and contains valid and relevant information. The check your are removing should be there. It ensures that interrupts are ignored if they are blocked by vcpu. > > Signed-off-by: Glauber Costa > CC: Gleb Natapov > --- > qemu-kvm-x86.c | 5 ++--- > 1 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/qemu-kvm-x86.c b/qemu-kvm-x86.c > index f80d82b..66ed6b5 100644 > --- a/qemu-kvm-x86.c > +++ b/qemu-kvm-x86.c > @@ -1393,9 +1393,8 @@ void kvm_arch_post_kvm_run(void *opaque, CPUState *env) > > int kvm_arch_has_work(CPUState *env) > { > - if (((env->interrupt_request & CPU_INTERRUPT_HARD) && > - (env->eflags & IF_MASK)) || > - (env->interrupt_request & CPU_INTERRUPT_NMI)) > + if (((env->interrupt_request & CPU_INTERRUPT_HARD) || > + (env->interrupt_request & CPU_INTERRUPT_NMI))) > return 1; > return 0; > } > -- > 1.6.2.2 -- Gleb.