From: Theodore Tso <tytso@mit.edu>
To: Eric Sandeen <sandeen@redhat.com>
Cc: ext4 development <linux-ext4@vger.kernel.org>,
Ric Wheeler <rwheeler@redhat.com>,
Justin Maggard <jmaggard10@gmail.com>
Subject: Re: [PATCH V2] libext2fs: use proper functions to set/clear block group flags
Date: Sun, 6 Sep 2009 12:29:48 -0400 [thread overview]
Message-ID: <20090906162948.GI3055@mit.edu> (raw)
In-Reply-To: <4A9EE55F.3030800@redhat.com>
On Wed, Sep 02, 2009 at 04:36:31PM -0500, Eric Sandeen wrote:
> As Justin & Ric reported, something like this on a
> 22T (sparse) bigfile:
>
> e2fsprogs/misc/mke2fs -E lazy_itable_init=1 \
> -O uninit_bg -b 4096 bigfile
> mount -o loop bigfile mnt/
> for I in `seq 1 5`; do mkdir mnt/$I; done
> umount mnt/
> e2fsprogs/e2fsck/e2fsck -f bigfile
>
> would give us corrupted block group checksums:
>
> <other problems related to uninit snipped>
> One or more block group descriptor checksums are invalid. Fix<y>? yes
>
> Group descriptor 6301 checksum is invalid. FIXED.
> Group descriptor 7799 checksum is invalid. FIXED.
>
> There wer=re a few places which accessed bg_flags directly
> rather than using the helper functions; fixing these seems
> to resolve the problem.
>
> V2: use _flag_clear not _flags_clear, which clears all flags ...
Added to the e2fsprogs 64-bits patch set (and thus the pu branch).
- Ted
prev parent reply other threads:[~2009-09-06 16:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-02 20:36 [PATCH] libext2fs: use proper functions to set/clear block group flags Eric Sandeen
2009-09-02 21:15 ` Eric Sandeen
2009-09-02 21:26 ` Justin Maggard
2009-09-02 21:36 ` [PATCH V2] " Eric Sandeen
2009-09-06 16:29 ` Theodore Tso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090906162948.GI3055@mit.edu \
--to=tytso@mit.edu \
--cc=jmaggard10@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=rwheeler@redhat.com \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.