From: Jean Delvare <khali@linux-fr.org>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH] hwmon: (abituguru3) Support multiple DMI
Date: Sun, 06 Sep 2009 16:23:20 +0000 [thread overview]
Message-ID: <20090906182320.4d2e212b@hyperion.delvare> (raw)
In-Reply-To: <1252170780-4141-1-git-send-email-alistair@devzero.co.uk>
On Sun, 6 Sep 2009 15:30:28 +0100, Alistair John Strachan wrote:
> Most known Abit motherboards have unique uguru chip IDs. However,
> some "refresh" boards keep the same chip ID but have a different
> DMI string. As our DMI board string matching is (necessarily)
> strict, some boards were failing DMI detection, and as the old
> probe method was also failing, the driver would not load.
>
> The only known boards affected by this problem are the IP35 Pro XE
> (vs IP35 Pro) and the AB9 Pro (vs AB9). Is it not sufficient to
> relax the match criteria, as some boards (e.g. the AB9 Quad GT)
> have different uguru chip IDs.
>
> This patch replaces the dmi_name string with a NULL terminated
> array of strings to be matched per uguru chip ID. It has been
> compile and runtime tested (thanks Rune).
>
> References: https://bugs.launchpad.net/bugs/298798
>
> Signed-off-by: Alistair John Strachan <alistair@devzero.co.uk>
> Tested-by: Rune Svendsen <runesvend@gmail.com>
> Cc: Rune Svendsen <runesvend@gmail.com>
> Cc: Hans de Goede <hdegoede@redhat.com>
> Cc: lm-sensors@lm-sensors.org
>
> ---
> drivers/hwmon/abituguru3.c | 77 +++++++++++++++++++++++---------------------
> 1 files changed, 40 insertions(+), 37 deletions(-)
Applied, thanks.
--
Jean Delvare
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
prev parent reply other threads:[~2009-09-06 16:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-05 17:13 [lm-sensors] [PATCH] hwmon: (abituguru3) Support multiple DMI Alistair John Strachan
2009-09-06 7:23 ` Hans de Goede
2009-09-06 9:15 ` Alistair John Strachan
2009-09-06 9:37 ` Hans de Goede
2009-09-06 12:03 ` Jean Delvare
2009-09-06 13:55 ` Alistair John Strachan
2009-09-06 14:06 ` Jean Delvare
2009-09-06 14:15 ` Rune Svendsen
2009-09-06 14:30 ` Alistair John Strachan
2009-09-06 14:41 ` Alistair John Strachan
2009-09-06 15:05 ` Rune Svendsen
2009-09-06 16:23 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090906182320.4d2e212b@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.