Re: [LTP] [PATCH 1/1] Containers: Pass a valid stack address to clone

["Serge E. Hallyn" <serue@us.ibm.com>]

Quoting Subrata Modak (subrata@linux.vnet.ibm.com):
> On Wed, 2009-09-02 at 16:13 -0400, Mike Frysinger wrote: 
> > On Wednesday 02 September 2009 10:10:27 Serge E. Hallyn wrote:
> > > Also fix the libnetns helper to, like the libclone one, special-case
> > > hppa and pass the bottom of the stack to clone2 for __ia64__ (as per
> > > the libclone example and the clone2 manpage).  I don't know and can't
> > > test whether it's right, but have to assume that one of the other was
> > > wrong.
> > 
> > please, let's stop screwing around with this and copying & pasting it 
> > everywhere.  create a new dedicate "ltp_clone" or similar function and stick 
> > the arch-specific logic there.
> > int ltp_clone(func ptr, stack base, stack size, clone flags, func args...)
> > -mike
> > -----------------------
> 
> Serge,
> 
> Did you post any new patches after Mikeś comments ?

No I haven't.  I agree with him, and see other cases which could
stand consolidation under syscalls/clone, fs/fs_bind/nsclone,
controllers/cgroup, security/tomoyo, security/selinux-testsuite,
audit-test, and misc/crash.

-serge

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list