From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Ml21D-0003Ys-BC for mharc-grub-devel@gnu.org; Tue, 08 Sep 2009 10:50:03 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ml21C-0003X2-4X for grub-devel@gnu.org; Tue, 08 Sep 2009 10:50:02 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ml217-0003PX-A2 for grub-devel@gnu.org; Tue, 08 Sep 2009 10:50:01 -0400 Received: from [199.232.76.173] (port=50483 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ml217-0003PI-6K for grub-devel@gnu.org; Tue, 08 Sep 2009 10:49:57 -0400 Received: from xvm-190-8.ghst.net ([217.70.190.8]:56633 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Ml216-0000SA-JG for grub-devel@gnu.org; Tue, 08 Sep 2009 10:49:56 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1Ml213-0008Ep-Dm for grub-devel@gnu.org; Tue, 08 Sep 2009 16:49:53 +0200 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1Ml212-0003b6-Oi for grub-devel@gnu.org; Tue, 08 Sep 2009 16:49:52 +0200 Date: Tue, 8 Sep 2009 16:49:52 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090908144952.GD13674@thorin> References: <1252260211.3895.79.camel@fz.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1252260211.3895.79.camel@fz.local> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: [PATCH] hide `Try 'help' for usage' if help doestn't exist in rescue mode X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Sep 2009 14:50:02 -0000 On Sun, Sep 06, 2009 at 08:03:31PM +0200, Felix Zielcke wrote: > I think we shouldn't tell users to type `help' if the command doestn't > exist in rescue mode, i.e. minicmd isn't included in core.img > This increases the size of kernel.img for me by 28 bytes. I think it's > worth. > > It's so small I don't bother to attach it: > > 2009-09-06 Felix Zielcke > > * kern/rescue_parser.c (grub_rescue_parse_line): Only suggest to try > `help' if the command exists. > > diff --git a/kern/rescue_parser.c b/kern/rescue_parser.c > index 79f32b8..1e0841e 100644 > --- a/kern/rescue_parser.c > +++ b/kern/rescue_parser.c > @@ -61,7 +61,8 @@ grub_rescue_parse_line (char *line, grub_reader_getline_t getline) > else > { > grub_printf ("Unknown command `%s'\n", name); > - grub_printf ("Try `help' for usage\n"); > + if (grub_command_find ("help")) > + grub_printf ("Try `help' for usage\n"); > } > > quit: Seems fine. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."