From: Greg KH <gregkh@suse.de>
To: Jayson King <dev@jaysonking.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
sunil.mushran@oracle.com, joel.becker@oracle.com
Subject: Re: [patch 00/48] 2.6.27.32-stable review
Date: Tue, 8 Sep 2009 20:08:43 -0700 [thread overview]
Message-ID: <20090909030843.GC10608@suse.de> (raw)
In-Reply-To: <4AA66E97.4050500@jaysonking.com>
On Tue, Sep 08, 2009 at 09:47:51AM -0500, Jayson King wrote:
> Greetings,
>
> Patch 41/48 (ocfs2: Initialize the...) of this series causes a build
> failure:
>
> fs/ocfs2/aops.c: In function ‘ocfs2_write_cluster’:
> fs/ocfs2/aops.c:1286: error: ‘should_zero’ undeclared (first use in this
> function)
> fs/ocfs2/aops.c:1286: error: (Each undeclared identifier is reported
> only once
> fs/ocfs2/aops.c:1286: error: for each function it appears in.)
> fs/ocfs2/aops.c: In function ‘ocfs2_write_cluster_by_desc’:
> fs/ocfs2/aops.c:1360: warning: passing argument 4 of
> ‘ocfs2_write_cluster’ makes pointer from integer without a cast
> fs/ocfs2/aops.c:1360: warning: passing argument 6 of
> ‘ocfs2_write_cluster’ from incompatible pointer type
> fs/ocfs2/aops.c:1360: warning: passing argument 7 of
> ‘ocfs2_write_cluster’ makes integer from pointer without a cast
> fs/ocfs2/aops.c:1360: error: too many arguments to function
> ‘ocfs2_write_cluster’
>
>
> A line from the upstream patch is missing in this patch:
>
> static int ocfs2_write_cluster(struct address_space *mapping,
> u32 phys, unsigned int unwritten,
> + unsigned int should_zero,
> struct ocfs2_alloc_context *data_ac,
> struct ocfs2_alloc_context *meta_ac,
> struct ocfs2_write_ctxt *wc, u32 cpos,
> loff_t user_pos, unsigned user_len)
>
>
> Attached is the corrected patch with the above line placed back in.
There was an add-on ocfs2 patch that should have now resolved this
issue. If you still have this problem with the released kernel, please
let me know.
thanks,
greg k-h
next prev parent reply other threads:[~2009-09-09 3:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-08 14:47 [patch 00/48] 2.6.27.32-stable review Jayson King
2009-09-09 3:08 ` Greg KH [this message]
2009-09-09 7:31 ` Michael Tokarev
2009-09-09 13:23 ` Greg KH
2009-09-09 18:28 ` Joel Becker
2009-09-09 18:36 ` Greg KH
2009-09-09 19:20 ` Chuck Ebbert
2009-09-09 20:15 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2009-09-09 14:30 Jayson King
2009-09-04 20:11 Greg KH
2009-09-06 22:58 ` Tilman Schmidt
2009-09-10 22:33 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090909030843.GC10608@suse.de \
--to=gregkh@suse.de \
--cc=dev@jaysonking.com \
--cc=joel.becker@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sunil.mushran@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.