All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Arnd Bergmann <arnd@arndb.de>, Nathan Lynch <ntl@pobox.com>,
	linux-kernel@vger.kernel.org,
	Containers <containers@lists.linux-foundation.org>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	mingo@elte.hu, torvalds@linux-foundation.org,
	Alexey Dobriyan <adobriyan@gmail.com>,
	Pavel Emelyanov <xemul@openvz.org>
Subject: Re: [RFC][v5][PATCH 8/8]: Define clone_with_pids() syscall
Date: Wed, 9 Sep 2009 11:03:03 -0700	[thread overview]
Message-ID: <20090909180303.GA21048@us.ibm.com> (raw)
In-Reply-To: <4AA7CF1F.3020408@zytor.com>

H. Peter Anvin [hpa@zytor.com] wrote:
| On 09/09/2009 05:19 AM, Arnd Bergmann wrote:
| > 
| > This is a complex problem. The structure above would need a conversion
| > for the pointer size that you can avoid by using a u64, but that introduces
| > another problem:
| > 
| > 2. use a single pointer, with variable length data structures:
| > 
| > struct pid_set {
| > 	int num_pids;
| > 	pid_t pids[0];
| > };
| > 
| > Since pid_t is always an int, you have no problem with padding or
| > incompatible types, but rely on a data structure definition that
| > is not in C89 (not sure about C99).

C90 or C99 below should work. Is it ok to use a data structure that is
not in C89 ? 

BTW, would it work if we defined 

	struct pid_set {
		u64 pids;
		int num_pids;
	}

where ->pids can be still be a pointer ? The data structure would
have the same size on all architectures.

Thanks for the input

Sukadev

  parent reply	other threads:[~2009-09-09 17:58 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-07 21:13 [RFC][v5] clone_with_pids() system call Sukadev Bhattiprolu
2009-09-07 21:13 ` Sukadev Bhattiprolu
2009-09-07 21:13 ` [RFC][v5][PATCH 1/8]: Factor out code to allocate pidmap page Sukadev Bhattiprolu
2009-09-07 21:14 ` [RFC][v5][PATCH 3/8] Make pid_max a pid_ns property Sukadev Bhattiprolu
     [not found] ` <20090907211302.GA5892-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-09-07 21:13   ` [RFC][v5][PATCH 1/8]: Factor out code to allocate pidmap page Sukadev Bhattiprolu
2009-09-07 21:14   ` [RFC][v5][PATCH 2/8]: Have alloc_pidmap() return actual error code Sukadev Bhattiprolu
2009-09-07 21:14     ` Sukadev Bhattiprolu
2009-09-07 21:14   ` [RFC][v5][PATCH 3/8] Make pid_max a pid_ns property Sukadev Bhattiprolu
2009-09-07 21:15   ` [RFC][v5][PATCH 4/8]: Add target_pid parameter to alloc_pidmap() Sukadev Bhattiprolu
2009-09-07 21:15     ` Sukadev Bhattiprolu
2009-09-08 14:16     ` Serge E. Hallyn
     [not found]     ` <20090907211506.GD6685-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-09-08 14:16       ` Serge E. Hallyn
2009-09-07 21:15   ` [RFC][v5][PATCH 5/8]: Add target_pids parameter to alloc_pid() Sukadev Bhattiprolu
2009-09-07 21:15   ` [RFC][v5][PATCH 6/8]: Add target_pids parameter to copy_process() Sukadev Bhattiprolu
2009-09-07 21:15     ` Sukadev Bhattiprolu
2009-09-07 21:16   ` [RFC][v5][PATCH 7/8]: Define do_fork_with_pids() Sukadev Bhattiprolu
2009-09-07 21:17   ` [RFC][v5][PATCH 8/8]: Define clone_with_pids() syscall Sukadev Bhattiprolu
2009-09-07 21:15 ` [RFC][v5][PATCH 5/8]: Add target_pids parameter to alloc_pid() Sukadev Bhattiprolu
2009-09-07 21:16 ` [RFC][v5][PATCH 7/8]: Define do_fork_with_pids() Sukadev Bhattiprolu
2009-09-07 21:17 ` [RFC][v5][PATCH 8/8]: Define clone_with_pids() syscall Sukadev Bhattiprolu
2009-09-08 18:19   ` Nathan Lynch
     [not found]     ` <m3zl95l2oz.fsf-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>
2009-09-09 12:19       ` Arnd Bergmann
2009-09-09 12:19         ` Arnd Bergmann
     [not found]         ` <200909091419.50496.arnd-r2nGTMty4D4@public.gmane.org>
2009-09-09 15:51           ` H. Peter Anvin
2009-09-09 15:51             ` H. Peter Anvin
     [not found]             ` <4AA7CF1F.3020408-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>
2009-09-09 18:03               ` Sukadev Bhattiprolu
2009-09-09 18:03             ` Sukadev Bhattiprolu [this message]
     [not found]               ` <20090909180303.GA21048-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-09-09 18:01                 ` H. Peter Anvin
2009-09-09 18:34                 ` Linus Torvalds
2009-09-09 18:01               ` H. Peter Anvin
2009-09-09 18:34               ` Linus Torvalds
     [not found]   ` <20090907211700.GH6685-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-09-08 18:19     ` Nathan Lynch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090909180303.GA21048@us.ibm.com \
    --to=sukadev@linux.vnet.ibm.com \
    --cc=adobriyan@gmail.com \
    --cc=arnd@arndb.de \
    --cc=containers@lists.linux-foundation.org \
    --cc=ebiederm@xmission.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=ntl@pobox.com \
    --cc=torvalds@linux-foundation.org \
    --cc=xemul@openvz.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.