All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 4/5] Remove BR2_TOPDIR_PREFIX and BR2_TOPDIR_SUFFIX
Date: Thu, 10 Sep 2009 08:30:10 +0200	[thread overview]
Message-ID: <20090910083010.116ab844@surf> (raw)
In-Reply-To: <20090909173535.GA17081@mx.loc>

Hi Bernhard,

Thanks for your comments!

Le Wed, 9 Sep 2009 19:35:35 +0200,
Bernhard Reutner-Fischer <rep.dot.nop@gmail.com> a ?crit :

Le Wed, 9 Sep 2009 19:35:35 +0200,
Bernhard Reutner-Fischer <rep.dot.nop@gmail.com> a ?crit :

> 1) COND_ARCH_FPU_SUFFIX is _completely_ useless, to say the least.

This one is removed by PATCH 5/5.

> 2) TOPDIR_PREFIX and TOPDIR_SUFFIX don't hurt and are convenient for
> some corner-cases. I'd keep them.

As they don't provide any additional value over O=, I'd prefer to keep
O=. One of the reason for which Buildroot is too complicated today is
because there are multiple ways of achieving the same thing. This
multitude of options is confusing for newcomers.

> 3) I'd much prefer if we could
> rather settle on
> TOOL_BUILD_DIR=$(BASE_DIR)/$(TOPDIR_PREFIX)$(ARCH)$(ARCH_FPU_SUFFIX)$(ARCH_MMU_SUFFIX)$(TOPDIR_SUFFIX)_toolchain
> BUILD_DIR
> =$(BASE_DIR)/$(TOPDIR_PREFIX)$(ARCH)$(ARCH_FPU_SUFFIX)$(ARCH_MMU_SUFFIX)$(TOPDIR_SUFFIX)_build
> 
> so you can conveniently rm -rf powerpc_nofpu_* (for example)

See PATCH 5/5, these are completely changed to something else.

Sincerly,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers and embedded Linux development,
consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2009-09-10  6:30 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-07 22:09 [Buildroot] [RFC] [PATCH 0/5] Buildroot cleanup Thomas Petazzoni
2009-09-07 22:09 ` [Buildroot] [PATCH 1/5] Remove the "project" feature Thomas Petazzoni
2009-09-08  6:27   ` Hans-Christian Egtvedt
2009-09-08  6:58     ` Sven Neumann
2009-09-08  7:07       ` Peter Korsgaard
2009-09-08  7:15         ` Sven Neumann
2009-09-08  7:23           ` Peter Korsgaard
2009-09-08  7:31             ` Thomas Petazzoni
2009-09-08  7:43               ` Peter Korsgaard
2009-09-08  7:49                 ` Thomas Petazzoni
2009-09-08  6:59     ` Peter Korsgaard
2009-09-08  7:16     ` Thomas Petazzoni
2009-09-08  7:06   ` Peter Korsgaard
     [not found]     ` <20090908092408.787e9cf7@surf>
2009-09-08  7:31       ` Peter Korsgaard
2009-09-07 22:09 ` [Buildroot] [PATCH 2/5] Remove the BOARD/LOCAL feature Thomas Petazzoni
2009-09-07 22:09 ` [Buildroot] [PATCH 3/5] By default, put the output in an output/ directory Thomas Petazzoni
2009-09-09 10:19   ` Peter Korsgaard
2009-09-09 11:28     ` Thomas Petazzoni
2009-09-07 22:09 ` [Buildroot] [PATCH 4/5] Remove BR2_TOPDIR_PREFIX and BR2_TOPDIR_SUFFIX Thomas Petazzoni
2009-09-09 17:35   ` Bernhard Reutner-Fischer
2009-09-10  6:30     ` Thomas Petazzoni [this message]
2009-09-10  7:33       ` Peter Korsgaard
2009-09-07 22:09 ` [Buildroot] [PATCH 5/5] Rename the output directories Thomas Petazzoni
2009-09-09  7:02   ` Peter Korsgaard
2009-09-09  7:22     ` Thomas Petazzoni
2009-09-09  7:37       ` Peter Korsgaard
2009-09-08 17:03 ` [Buildroot] [RFC] [PATCH 0/5] Buildroot cleanup Will Newton
2009-09-08 19:13   ` Jonathan dumaresq
2009-09-08 21:20   ` Peter Korsgaard
2009-09-09  9:36     ` Will Newton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090910083010.116ab844@surf \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.