From: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: linux-kernel@vger.kernel.org, Oren Laadan <orenl@cs.columbia.edu>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Alexey Dobriyan <adobriyan@gmail.com>,
Pavel Emelyanov <xemul@openvz.org>, Andrew Morton <akpm@osdl.org>,
torvalds@linux-foundation.org, mikew@google.com, mingo@elte.hu,
hpa@zytor.com, Nathan Lynch <nathanl@austin.ibm.com>,
arnd@arndb.de, Containers <containers@lists.linux-foundation.org>,
sukadev@us.ibm.com
Subject: Re: [RFC][v6][PATCH 9/9]: Document clone_with_pids() syscall
Date: Thu, 10 Sep 2009 09:31:40 -0700 [thread overview]
Message-ID: <20090910163140.GA14158@us.ibm.com> (raw)
In-Reply-To: <20090910082659.033ab8fd.randy.dunlap@oracle.com>
Thanks for the review. Will fix the typos.
Randy Dunlap [randy.dunlap@oracle.com] wrote:
| > +Example:
| > +
| > + struct pid_set pid_set { 3, {0, 99, 177} };
| > + void *child_stack = malloc(STACKSIZE);
| > +
| > + /* set up child_stack, like with clone() */
| > + rc = clone_with_pids(clone_flags, child_stack, NULL, NULL, &pid_set);
| > +
| > + if (rc < 0) {
| > + perror("clone_with_pids()");
| > + exit(1);
| > + }
|
| What happens when one of the pids is busy? Say the last one in the
| example above [177]. Are the first 2 children already cloned
| or are all pids checked for availability before cloning?
Only _one_ one child process is created (on success). With nested pid
namespaces a process is known by different pids (or pid numbers to be
precise) - one in each pid namespace.
(BTW, looks like we did not document pid-namespaces in the Documentation/
But please see the CLONE_NEWPID section of a recent version of clone(2)).
In short, the above clone_with_pids() tries to create a single child process
with the given pids.
| If the latter, is there a race there?
| and what value is returned?
There is no race - bc just a single process is being created.
If any of the pids are not available, the child process is not created
and the system call returns -EBUSY (if the user requested say 99 and 99
is in use by another process)
next prev parent reply other threads:[~2009-09-10 16:26 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-10 6:06 [RFC][v6][PATCH 0/9] clone_with_pids() syscall Sukadev Bhattiprolu
2009-09-10 6:08 ` [RFC][v6][PATCH 1/9]: Factor out code to allocate pidmap page Sukadev Bhattiprolu
2009-09-10 6:09 ` [RFC][v6][PATCH 2/9]: Have alloc_pidmap() return actual error code Sukadev Bhattiprolu
2009-09-10 6:09 ` [RFC][v6][PATCH 3/9] Make pid_max a pid_ns property Sukadev Bhattiprolu
2009-09-10 6:09 ` [RFC][v6][PATCH 4/9]: Add target_pid parameter to alloc_pidmap() Sukadev Bhattiprolu
2009-09-10 6:10 ` [RFC][v6][PATCH 5/9]: Add target_pids parameter to alloc_pid() Sukadev Bhattiprolu
2009-09-10 6:11 ` [RFC][v6][PATCH 6/9]: Add target_pids parameter to copy_process() Sukadev Bhattiprolu
2009-09-10 6:12 ` [RFC][v6][PATCH 7/9]: Define do_fork_with_pids() Sukadev Bhattiprolu
[not found] ` <20090910061227.GF25883-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-09-10 7:05 ` Arnd Bergmann
2009-09-10 7:05 ` Arnd Bergmann
2009-09-10 21:29 ` Sukadev Bhattiprolu
[not found] ` <200909100905.35817.arnd-r2nGTMty4D4@public.gmane.org>
2009-09-10 21:29 ` Sukadev Bhattiprolu
2009-09-10 6:13 ` [RFC][v6][PATCH 8/9]: Define clone_with_pids() syscall Sukadev Bhattiprolu
[not found] ` <20090910061301.GG25883-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-09-10 7:31 ` Arnd Bergmann
2009-09-10 7:31 ` Arnd Bergmann
2009-09-10 21:28 ` Sukadev Bhattiprolu
[not found] ` <20090910212837.GA31459-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-09-11 10:31 ` Arnd Bergmann
2009-09-11 10:31 ` Arnd Bergmann
[not found] ` <200909111231.30495.arnd-r2nGTMty4D4@public.gmane.org>
2009-09-11 11:00 ` Louis Rilling
2009-09-11 11:00 ` Louis Rilling
2009-09-11 11:12 ` Arnd Bergmann
[not found] ` <20090911110056.GA12824-Hu8+6S1rdjywhHL9vcZdMVaTQe2KTcn/@public.gmane.org>
2009-09-11 11:12 ` Arnd Bergmann
[not found] ` <200909100931.25585.arnd-r2nGTMty4D4@public.gmane.org>
2009-09-10 21:28 ` Sukadev Bhattiprolu
[not found] ` <20090910060627.GA24343-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-09-10 6:11 ` [RFC][v6][PATCH 6/9]: Add target_pids parameter to copy_process() Sukadev Bhattiprolu
2009-09-10 6:12 ` [RFC][v6][PATCH 7/9]: Define do_fork_with_pids() Sukadev Bhattiprolu
2009-09-10 6:13 ` [RFC][v6][PATCH 8/9]: Define clone_with_pids() syscall Sukadev Bhattiprolu
2009-09-10 6:14 ` [RFC][v6][PATCH 9/9]: Document " Sukadev Bhattiprolu
2009-09-10 6:14 ` Sukadev Bhattiprolu
2009-09-10 15:26 ` Randy Dunlap
[not found] ` <20090910082659.033ab8fd.randy.dunlap-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2009-09-10 16:31 ` Sukadev Bhattiprolu
2009-09-10 16:31 ` Sukadev Bhattiprolu [this message]
[not found] ` <20090910061413.GH25883-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-09-10 15:26 ` Randy Dunlap
2009-09-11 11:22 ` [RFC][v6][PATCH 0/9] " Peter Zijlstra
2009-09-11 11:34 ` Arnd Bergmann
2009-09-11 11:40 ` Peter Zijlstra
2009-09-11 11:50 ` Arnd Bergmann
2009-09-11 16:47 ` Sukadev Bhattiprolu
2009-09-11 17:00 ` Peter Zijlstra
2009-09-12 17:19 ` Sukadev Bhattiprolu
2009-09-13 14:36 ` Arnd Bergmann
2009-09-14 7:14 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090910163140.GA14158@us.ibm.com \
--to=sukadev@linux.vnet.ibm.com \
--cc=adobriyan@gmail.com \
--cc=akpm@osdl.org \
--cc=arnd@arndb.de \
--cc=containers@lists.linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mikew@google.com \
--cc=mingo@elte.hu \
--cc=nathanl@austin.ibm.com \
--cc=orenl@cs.columbia.edu \
--cc=randy.dunlap@oracle.com \
--cc=sukadev@us.ibm.com \
--cc=torvalds@linux-foundation.org \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.