From: Frans Pop <elendil@planet.nl>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
Zhang Rui <rui.zhang@intel.com>
Subject: Re: [PATCH 5/6] thermal: Only set passive_delay for forced passive cooling
Date: Thu, 10 Sep 2009 18:07:12 +0200 [thread overview]
Message-ID: <200909101807.13874.elendil@planet.nl> (raw)
In-Reply-To: <20090826162537.GC15868@srcf.ucam.org>
Hi Matthew,
On Wednesday 26 August 2009, Matthew Garrett wrote:
> On Wed, Aug 26, 2009 at 06:17:24PM +0200, Frans Pop wrote:
> > Setting polling_delay is useless as passive_delay has priority,
> > so the value shown in proc isn't the actual polling delay. It
> > also gives the impression to the user that he can change the
> > polling interval through proc, while in fact he can't.
> >
> > Also, unset passive_delay when the forced passive trip point is
> > unbound to allow polling to be disabled.
> >
> > Signed-off-by: Frans Pop <elendil@planet.nl>
> > Cc: Matthew Garrett <mjg@redhat.com>
> > Cc: Zhang Rui <rui.zhang@intel.com>
>
> I'll look over this - I seem to remember having some reason to set
> that, but it escapes me now.
Have you had a chance to check this?
Cheers,
FJP
next prev parent reply other threads:[~2009-09-10 16:07 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-26 16:17 [PATCH 0/6] thermal: improvements re. forced passive cooling Frans Pop
2009-08-26 16:17 ` [PATCH 1/6] thermal: sysfs-api.txt - reformat for improved readability Frans Pop
2009-08-26 16:17 ` [PATCH 2/6] thermal: sysfs-api.txt - document passive attribute for thermal zones Frans Pop
2009-08-31 8:18 ` Zhang Rui
2009-08-31 11:19 ` Frans Pop
2009-09-01 0:44 ` Zhang Rui
2009-09-02 20:02 ` Pavel Machek
2009-09-03 14:34 ` Frans Pop
2009-08-26 16:17 ` [PATCH 3/6] acpi: thermal: display forced passive trip points in proc Frans Pop
2009-08-31 8:20 ` Zhang Rui
2009-08-26 16:17 ` [PATCH 4/6] thermal: add sanity check for the passive attribute Frans Pop
2009-08-26 16:23 ` Matthew Garrett
2009-08-26 16:48 ` Frans Pop
2009-08-26 16:48 ` Frans Pop
2009-08-31 8:33 ` Zhang Rui
2009-08-31 8:33 ` Zhang Rui
2009-08-31 10:30 ` Frans Pop
2009-08-31 10:30 ` Frans Pop
2009-09-03 6:10 ` Zhang Rui
2009-09-03 6:10 ` Zhang Rui
2009-09-03 14:33 ` [PATCH 4/6,v2] " Frans Pop
2009-09-03 14:33 ` Frans Pop
2009-08-26 16:17 ` [PATCH 5/6] thermal: Only set passive_delay for forced passive cooling Frans Pop
2009-08-26 16:25 ` Matthew Garrett
2009-09-10 16:07 ` Frans Pop [this message]
2009-09-10 16:15 ` Matthew Garrett
2009-08-26 16:17 ` [PATCH 6/6] thermal: disable polling if passive_delay and polling_delay are both unset Frans Pop
2009-08-26 16:25 ` Matthew Garrett
2009-09-11 6:08 ` [PATCH 0/6] thermal: improvements re. forced passive cooling Frans Pop
-- strict thread matches above, loose matches on Subject: below --
2009-10-26 7:38 [PATCH 0/6] [resend] " Frans Pop
2009-10-26 7:39 ` [PATCH 5/6] thermal: Only set passive_delay for forced_passive cooling Frans Pop
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200909101807.13874.elendil@planet.nl \
--to=elendil@planet.nl \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.