From: Andrew Morton <akpm@linux-foundation.org>
To: Zhenyu Wang <zhenyuw@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
stable@kernel.org, stern@rowland.harvard.edu
Subject: Re: [PATCH 1/3] agp/intel: remove restore in resume
Date: Thu, 10 Sep 2009 18:22:57 -0700 [thread overview]
Message-ID: <20090910182257.91c66541.akpm@linux-foundation.org> (raw)
In-Reply-To: <20090911010342.GA6819@zhen-devel.sh.intel.com>
On Fri, 11 Sep 2009 09:03:42 +0800 Zhenyu Wang <zhenyuw@linux.intel.com> wrote:
> On 2009.09.10 13:42:52 -0700, Andrew Morton wrote:
> > On Fri, 4 Sep 2009 09:43:34 +0800
> > Zhenyu Wang <zhenyuw@linux.intel.com> wrote:
> >
> > > As early pci resume has already restored config for host
> > > bridge and graphics device, don't need to restore it again,
> > > which might cause problem on some chips, like 845G tested by
> > > Alan Stern.
> > >
> > > Cc: Stable Team <stable@kernel.org>
> > > Cc: Alan Stern <stern@rowland.harvard.edu>
> > > Signed-off-by: Zhenyu Wang <zhenyuw@linux.intel.com>
> >
> > Why were these patches cc'ed to stable@kernel.org? There's nothing in
> > the changelog which explains why the problem which is being fixed is
> > sufficiently serious to warrant backporting the patch.
>
> Sorry, Andrew. I wasn't awared that an earlier version of this patch
> has already been merged, and this patch fixed resume issue on Alan's
> 845G, which was discussed on linux-pm list, I should have made more
> clear note about that. We've also seen other resume failure bugs, which
> might be relate to this one. So I think it should be fine for stable.
We still don't have a changelog for this patch which explains to the
-stable maintainers (and those who follow -stable commits):
a) what bug this patch fixes and
b) why they should merge it - this should be ovbious if a) is provided.
this isn't pointless paperwork - it matters to those who maintain and
use the -stable tree. Vague references to traffic on the linux-pm list
aren't at all useful.
>From my reading of the above, it appears that Alan was experiencing
<secretbug> and this patch was tested and fixed it, yes?
> >
> > Was there a [patch 3/3]? I didn't receive it.
>
> sorry, my mistake, the 3/3 commit on my tree is not ready to send,
> forget to make git format-patch happy.
OK.
next prev parent reply other threads:[~2009-09-11 1:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-04 1:43 [PATCH 1/3] agp/intel: remove restore in resume Zhenyu Wang
2009-09-04 1:43 ` [PATCH 2/3] drm/i915: " Zhenyu Wang
2009-09-10 20:42 ` [PATCH 1/3] agp/intel: " Andrew Morton
2009-09-11 1:03 ` Zhenyu Wang
2009-09-11 1:22 ` Andrew Morton [this message]
2009-09-11 1:49 ` Zhenyu Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090910182257.91c66541.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=zhenyuw@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.