From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MlpGH-0004yQ-7m for mharc-grub-devel@gnu.org; Thu, 10 Sep 2009 15:24:53 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MlpGF-0004yL-Os for grub-devel@gnu.org; Thu, 10 Sep 2009 15:24:51 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MlpGA-0004y8-AO for grub-devel@gnu.org; Thu, 10 Sep 2009 15:24:50 -0400 Received: from [199.232.76.173] (port=35591 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MlpGA-0004y5-4n for grub-devel@gnu.org; Thu, 10 Sep 2009 15:24:46 -0400 Received: from smarthost03.mail.zen.net.uk ([212.23.3.142]:59770) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MlpG9-0003U5-SB for grub-devel@gnu.org; Thu, 10 Sep 2009 15:24:46 -0400 Received: from [82.69.40.219] (helo=riva.pelham.vpn.ucam.org) by smarthost03.mail.zen.net.uk with esmtp (Exim 4.63) (envelope-from ) id 1MlpG9-0001vH-2U; Thu, 10 Sep 2009 19:24:45 +0000 Received: from cjwatson by riva.pelham.vpn.ucam.org with local (Exim 3.36 #1 (Debian)) id 1MlpG8-0006Rg-00; Thu, 10 Sep 2009 20:24:44 +0100 Date: Thu, 10 Sep 2009 20:24:44 +0100 From: Colin Watson To: The development of GRUB 2 Message-ID: <20090910192444.GC13423@riva.ucam.org> References: <20090910163914.GB13423@riva.ucam.org> <20090910191754.GD18736@thorin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090910191754.GD18736@thorin> User-Agent: Mutt/1.5.18 (2008-05-17) X-Originating-Smarthost03-IP: [82.69.40.219] X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Cc: Agostino Russo Subject: Re: [PATCH] 64-bit file sizes in NTFS X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Sep 2009 19:24:51 -0000 On Thu, Sep 10, 2009 at 09:17:54PM +0200, Robert Millan wrote: > On Thu, Sep 10, 2009 at 05:39:14PM +0100, Colin Watson wrote: > > Index: include/grub/ntfs.h > > =================================================================== > > --- include/grub/ntfs.h (revision 2584) > > +++ include/grub/ntfs.h (working copy) > > @@ -133,7 +133,7 @@ struct grub_fshelp_node > > { > > struct grub_ntfs_data *data; > > char *buf; > > - grub_uint32_t size; > > + grub_uint64_t size; > > grub_uint32_t ino; > > int inode_read; > > struct grub_ntfs_attr attr; > > Would this change offsets in subsequent struct fields? (I notice it's not > packed, but I always forget the alignment rules...) It probably would, but I don't think anything cares, does it? This data structure is purely internal - it isn't read from disk in a way that expects structures to line up. -- Colin Watson [cjwatson@ubuntu.com]