From: David Miller <davem@davemloft.net>
To: roel.kluin@gmail.com
Cc: chas@cmf.nrl.navy.mil, linux-atm-general@lists.sourceforge.net,
netdev@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [PATCH] atm: dereference of he_dev->rbps_virt in he_init_group()
Date: Fri, 11 Sep 2009 12:37:25 -0700 (PDT) [thread overview]
Message-ID: <20090911.123725.223971259.davem@davemloft.net> (raw)
In-Reply-To: <4AA25B06.2090703@gmail.com>
From: Roel Kluin <roel.kluin@gmail.com>
Date: Sat, 05 Sep 2009 14:35:18 +0200
> he_dev->rbps_virt or he_dev->rbpl_virt allocation may fail, so check
> them. Make sure that he_init_group() cleans up after errors.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
>> These new return statements will both leak resources allocated
>> earlier.
>>
>> All the caller is going to do is return -ENOMEM as well and
>> it does not cleanup actions at all.
>>
>> Please fix this up.
>
> I am new to this api, so please review.
Looks ok, applied, thanks.
next prev parent reply other threads:[~2009-09-11 19:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-29 18:56 [PATCH] atm: dereference of he_dev->rbps_virt in he_init_group() Roel Kluin
2009-08-29 18:59 ` Roel Kluin
2009-09-03 6:25 ` David Miller
2009-09-05 12:35 ` Roel Kluin
2009-09-11 19:37 ` David Miller [this message]
2009-09-11 19:51 ` David Miller
2009-09-19 18:16 ` Roel Kluin
2009-09-19 18:27 ` Joe Perches
2009-09-20 17:11 ` Roel Kluin
2009-09-22 21:25 ` David Miller
2009-09-26 13:20 ` Roel Kluin
2009-09-27 3:26 ` David Miller
2009-09-28 8:58 ` Roel Kluin
2009-09-28 19:46 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090911.123725.223971259.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=chas@cmf.nrl.navy.mil \
--cc=linux-atm-general@lists.sourceforge.net \
--cc=netdev@vger.kernel.org \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.