From: Jens Axboe <jens.axboe@oracle.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
chris.mason@oracle.com, tytso@mit.edu, akpm@linux-foundation.org,
jack@suse.cz, trond.myklebust@fys.uio.no
Subject: Re: [PATCH 2/4] Assign bdi in super_block
Date: Fri, 11 Sep 2009 20:12:27 +0200 [thread overview]
Message-ID: <20090911181227.GM14984@kernel.dk> (raw)
In-Reply-To: <20090911180106.GB19598@infradead.org>
On Fri, Sep 11 2009, Christoph Hellwig wrote:
> On Fri, Sep 11, 2009 at 01:50:30PM +0200, Jens Axboe wrote:
> > We do this automatically in get_sb_bdev() from the set_bdev_super()
> > callback. Filesystems that have their own private backing_dev_info
> > must assign that in ->fill_super().
> >
> > Note that ->s_bdi assignment is required for proper writeback!
>
> Looks good to me. Can we get rid of BDI_CAP_NO_WRITEBACK with this by
> simply not assigning a bdi?
Good question, I was indeed looking for an sb equivalent of that bdi
flag. And now ->s_bdi being set or not is indeed that. Some of our
generated writeback originates at the bdi level though, so we may or may
not have the sb. From a quick look at fs-writeback.c, it looks feasible
though. I'll try.
Can I take that as an acked-by?
--
Jens Axboe
next prev parent reply other threads:[~2009-09-11 18:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-11 11:50 [PATCH 0/4] Post merge per-bdi writeback patches Jens Axboe
2009-09-11 11:50 ` [PATCH 1/4] writeback: merely wakeup flusher thread if work allocation fails for WB_SYNC_NONE Jens Axboe
2009-09-11 17:59 ` Christoph Hellwig
2009-09-11 11:50 ` [PATCH 2/4] Assign bdi in super_block Jens Axboe
2009-09-11 18:01 ` Christoph Hellwig
2009-09-11 18:12 ` Jens Axboe [this message]
2009-09-11 18:16 ` Christoph Hellwig
2009-09-11 11:50 ` [PATCH 3/4] writeback: only use bdi_writeback_all() for WB_SYNC_NONE writeout Jens Axboe
2009-09-11 18:09 ` Christoph Hellwig
2009-09-11 18:14 ` Jens Axboe
2009-09-13 18:20 ` Jens Axboe
2009-09-11 11:50 ` [PATCH 4/4] writeback: use RCU to protect bdi_list Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090911181227.GM14984@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=chris.mason@oracle.com \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=trond.myklebust@fys.uio.no \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.