From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] libfs: return error code on failed attr set
Date: Fri, 11 Sep 2009 20:29:30 +0200
Message-ID: <20090911182930.GA13500@lst.de>
References: <20090911105031.GA17315@localhost>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Andrew Morton <akpm@linux-foundation.org>,
	"Theodore Ts'o" <tytso@mit.edu>, Al Viro <viro@zeniv.linux.org.uk>,
	Christoph Hellwig <hch@lst.de>, Nick Piggin <npiggin@suse.de>,
	linux-fsdevel@vger.kernel.org
To: Wu Fengguang <fengguang.wu@intel.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from verein.lst.de ([213.95.11.210]:58409 "EHLO verein.lst.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1755764AbZIKSaJ (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
	Fri, 11 Sep 2009 14:30:09 -0400
Content-Disposition: inline
In-Reply-To: <20090911105031.GA17315@localhost>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Fri, Sep 11, 2009 at 06:50:31PM +0800, Wu Fengguang wrote:
> Currently all simple_attr.set handlers return 0 on success and negative
> codes on error. Fix simple_attr_write() to return these error codes.

Looks good to me assuming you actually audited all the implementations
to do the right thing.