All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Serge E. Hallyn" <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
To: Oren Laadan <orenl-RdfvBDnrOixBDgjK7y7TUQ@public.gmane.org>
Cc: Linux Containers <containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org>
Subject: Re: [PATCH 1/1] cr: add a few more ckpt_write_err()s
Date: Fri, 11 Sep 2009 16:27:42 -0500	[thread overview]
Message-ID: <20090911212742.GB15329@us.ibm.com> (raw)
In-Reply-To: <4AAABE01.1080807-RdfvBDnrOixBDgjK7y7TUQ@public.gmane.org>

Quoting Oren Laadan (orenl-RdfvBDnrOixBDgjK7y7TUQ@public.gmane.org):
> 
> I wonder if it can be useful to decide on a common "format", that
> can be useful in the future for automatic error analysis. E.g:
> 
> "[PID %d ERR %d]: .....", for error with a specific task, and
> "[PID %d ERR %d OBJ %d]: ......" for error with an object, and so on.
> 
> Or even a bit more fancy, like:
> 
> 	ckpt_write_err("EO", "error message %p blah", err, obj, ptr);
> 			SPEC   FMT		      VARS...
> 
> Which ckpt_write_err() will translate to
> 
> 	sprintf(s, "[PID %d ERR %d] FMT", VARS...);
> 
> So the SPEC "EO" (stands for ERR, OBJ) becomes "[PID %d ERR %d OBJ %d]: "
> (pid is mandatory, the rest requested by the caller):
> 	E -> ERR %d
> 	O -> OBJ %d
> 	P -> PTR %p
> 	S -> SYM %pS
> 	etc...

Yes, it'd be useful.  BTW it also would be useful to have mktree/
restart auto-detect such error strings and report them.

-serge

  parent reply	other threads:[~2009-09-11 21:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-10 22:33 [PATCH 1/1] cr: add a few more ckpt_write_err()s Serge E. Hallyn
     [not found] ` <20090910223344.GA11718-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-09-11 21:15   ` Oren Laadan
     [not found]     ` <4AAABE01.1080807-RdfvBDnrOixBDgjK7y7TUQ@public.gmane.org>
2009-09-11 21:27       ` Serge E. Hallyn [this message]
     [not found]         ` <20090911212742.GB15329-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-09-14 12:47           ` Oren Laadan
     [not found]             ` <4AAE3B47.9020106-RdfvBDnrOixBDgjK7y7TUQ@public.gmane.org>
2009-09-14 13:24               ` Serge E. Hallyn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090911212742.GB15329@us.ibm.com \
    --to=serue-r/jw6+rmf7hqt0dzr+alfa@public.gmane.org \
    --cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
    --cc=orenl-RdfvBDnrOixBDgjK7y7TUQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.